Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api_models): remove redundant RoutingAlgorithm enum #2634

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor(api_models): remove redundant RoutingAlgorithm enum #2634

wants to merge 4 commits into from

Conversation

tinu-hareesswar
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

refactor(router): remove redundant router enum

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@tinu-hareesswar tinu-hareesswar added C-doc Category: Documentation updates S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 18, 2023
@tinu-hareesswar tinu-hareesswar self-assigned this Oct 18, 2023
@tinu-hareesswar tinu-hareesswar requested a review from a team as a code owner October 18, 2023 14:28
@SanchithHegde SanchithHegde changed the title refactor(router): remove redundant router enum refactor(api_models): remove redundantRoutingAlgorithm enum Oct 18, 2023
SanchithHegde
SanchithHegde previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SanchithHegde SanchithHegde added A-framework Area: Framework M-api-contract-changes Metadata: This PR involves API contract changes labels Oct 18, 2023
@ShankarSinghC ShankarSinghC requested a review from vspecky October 19, 2023 14:54
@SanchithHegde SanchithHegde changed the title refactor(api_models): remove redundantRoutingAlgorithm enum refactor(api_models): remove redundant RoutingAlgorithm enum Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@vspecky vspecky Awaiting requested review from vspecky

At least 2 approving reviews are required to merge this pull request.

Assignees

@tinu-hareesswar tinu-hareesswar

Labels
A-framework Area: Framework C-doc Category: Documentation updates M-api-contract-changes Metadata: This PR involves API contract changes S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tinu-hareesswar @SanchithHegde @prajjwalkumar17 @ShankarSinghC