Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple_pay): add support for decrypted apple pay token for checkout #2628

Merged
merged 9 commits into from
Oct 18, 2023

Conversation

ShankarSinghC
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This pr is to add support for decrypted apple pay token for checkout so that apple pay payments can be made using simplified apple pay flow.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

simplified flow
Screenshot 2023-10-18 at 3 43 34 PM
Screenshot 2023-10-18 at 3 44 44 PM
manual_flow
Screenshot 2023-10-18 at 3 46 18 PM
Screenshot 2023-10-18 at 3 51 05 PM

Test case :-
Pass the below metadata in the connector create
Manual flow

"metadata": {
        "apple_pay_combined": {
            "manual": {
                "session_token_data": {
                    "initiative": "web",
                    "certificate": "certificate",
                    "display_name": "checkoutapple",
                    "certificate_keys": "certificate_keys",
                    "initiative_context": "initiative_context",
                    "merchant_identifier": "merchant_identifier"
                },
                "payment_request_data": {
                    "label": "applepay",
                    "supported_networks": [
                        "visa",
                        "masterCard",
                        "amex",
                        "discover"
                    ],
                    "merchant_capabilities": [
                        "supports3DS"
                    ]
                }
            }
        }
    }

Simplified flow

"metadata": {
        "apple_pay_combined": {
            "simplified": {
                "session_token_data": {
                    "initiative_context": "initiative_context"
                },
                "payment_request_data": {
                    "label": "applepay",
                    "supported_networks": [
                        "visa",
                        "masterCard",
                        "amex",
                        "discover"
                    ],
                    "merchant_capabilities": [
                        "supports3DS"
                    ]
                }
            }
        }
    }

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

Sorry, something went wrong.

@ShankarSinghC ShankarSinghC added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Oct 18, 2023
@ShankarSinghC ShankarSinghC added this to the October 2023 Milestone milestone Oct 18, 2023
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner October 18, 2023 10:45
@ShankarSinghC ShankarSinghC self-assigned this Oct 18, 2023
srujanchikke
srujanchikke previously approved these changes Oct 18, 2023
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Sangamesh26 Sangamesh26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@likhinbopanna likhinbopanna added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 794dbc6 Oct 18, 2023
@likhinbopanna likhinbopanna deleted the new_apple_pay_flow_for_checkout branch October 18, 2023 13:27
@ShankarSinghC ShankarSinghC removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature Category: Feature request or enhancement
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants