-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(apple_pay): add support for decrypted apple pay token for checkout #2628
Merged
+44
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShankarSinghC
added
C-feature
Category: Feature request or enhancement
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
R-waiting-on-L1
Review: Waiting on L1 reviewer
labels
Oct 18, 2023
srujanchikke
previously approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
prajjwalkumar17
previously approved these changes
Oct 18, 2023
Sangamesh26
suggested changes
Oct 18, 2023
…juspay/hyperswitch into new_apple_pay_flow_for_checkout
Sangamesh26
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
srujanchikke
approved these changes
Oct 18, 2023
likhinbopanna
approved these changes
Oct 18, 2023
ShankarSinghC
removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
R-waiting-on-L1
Review: Waiting on L1 reviewer
labels
Oct 19, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This pr is to add support for decrypted apple pay token for checkout so that apple pay payments can be made using
simplified
apple pay flow.Additional Changes
Motivation and Context
How did you test it?
simplified flow
manual_flow
Test case :-
Pass the below metadata in the connector create
Manual flow
Simplified flow
Checklist
cargo +nightly fmt --all
cargo clippy