refactor(connector): [CyberSource] Enhance currency Mapping with ConnectorCurrencyCommon Trait #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-conventions-not-followed
mdrokz
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
|
Hey @mdrokz, could you address the failing CI checks? |
SanchithHegde
added
A-connector-integration
Just synced the changes from main can you run the CI checks again ? |
|
@mdrokz The formatting check is failing, could you please address it? |
Done |
|
@SanchithHegde can you review this ? |
SanchithHegde
added
S-waiting-on-review
srujanchikke
requested changes
Oct 22, 2023
| @@ -109,6 +140,70 @@ fn build_bill_to( | |||
| }) | |||
| } | |||
|
|
|||
| impl TryFrom<&CybersourceRouterData<&types::PaymentsAuthorizeRouterData>> | |||
There was a problem hiding this comment.
Instead of using new try_from , you can edit the exisiting try_from
Comment on lines
207
to
209
| impl TryFrom<&types::PaymentsAuthorizeRouterData> for CybersourcePaymentsRequest { | ||
| type Error = error_stack::Report<errors::ConnectorError>; | ||
| fn try_from(item: &types::PaymentsAuthorizeRouterData) -> Result<Self, Self::Error> { |
There was a problem hiding this comment.
Suggested change
| impl TryFrom<&types::PaymentsAuthorizeRouterData> for CybersourcePaymentsRequest { | |
| type Error = error_stack::Report<errors::ConnectorError>; | |
| fn try_from(item: &types::PaymentsAuthorizeRouterData) -> Result<Self, Self::Error> { | |
| impl TryFrom<&CybersourceRouterData<&types::PaymentsAuthorizeRouterData>> for CybersourcePaymentsRequest { | |
| type Error = error_stack::Report<errors::ConnectorError>; | |
| fn try_from(item: &CybersourceRouterData<&types::PaymentsAuthorizeRouterData>) -> Result<Self, Self::Error> { |
There was a problem hiding this comment.
Done i removed the old try form since both of them were same.
Sangamesh26
approved these changes
Oct 25, 2023
SanchithHegde
approved these changes
Oct 25, 2023
SanchithHegde
added
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR implements
get_currency_unitfor cybersource to convert payments fromBasetoMinorit also implements router data to handle the conversion.Additional Changes
Motivation and Context
Closes #2222
How did you test it?
I tested by sending a payment request & verifying the amount is showed in minor units in the cybersource console
Checklist
cargo +nightly fmt --allcargo clippy