Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(payment_connector): allow connector label to be updated #2622

Merged
merged 7 commits into from
Oct 18, 2023
Merged

refactor(payment_connector): allow connector label to be updated #2622

merged 7 commits into from
Oct 18, 2023

Conversation

Narayanbhat166
Copy link
Member

@Narayanbhat166 Narayanbhat166 commented Oct 18, 2023 •
edited
Loading

Type of Change

  • Refactoring

Description

This change will allow the connector_label to be passed in the create and update request, in create if it is not passed then the default connector label will be created in the form of connector_name_profile_name.

Additional Changes

  • This PR modifies the API contract

Motivation and Context

Allow custom labels to be passed for a connector.

How did you test it?

  • Create a connector with custom connector label.
    Screenshot 2023-10-18 at 11 52 20 AM

  • Update the connector with another connector label.
    Screenshot 2023-10-18 at 12 17 01 PM

  • Postman tests
    Screenshot 2023-10-18 at 4 45 43 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@Narayanbhat166 Narayanbhat166 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 18, 2023
@Narayanbhat166 Narayanbhat166 added this to the October 2023 Milestone milestone Oct 18, 2023
@Narayanbhat166 Narayanbhat166 requested review from a team as code owners October 18, 2023 06:47
@Narayanbhat166 Narayanbhat166 self-assigned this Oct 18, 2023
@Narayanbhat166 Narayanbhat166 changed the title refactor(payment_connector): refactor connector label refactor(payment_connector): allow connector label to be updated Oct 18, 2023
ThisIsMani
ThisIsMani previously approved these changes Oct 18, 2023
View reviewed changes
@Narayanbhat166 Narayanbhat166 requested a review from a team as a code owner October 18, 2023 10:22
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit c86ac9b Oct 18, 2023
9 of 11 checks passed
@Gnanasundari24 Gnanasundari24 deleted the refactor_connector_label branch October 18, 2023 13:31
@SanchithHegde SanchithHegde added A-core Area: Core flows and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 24, 2023
@SanchithHegde SanchithHegde added the C-refactor Category: Refactor label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnanasundari24 Gnanasundari24 Gnanasundari24 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ThisIsMani ThisIsMani ThisIsMani left review comments

@racnan racnan Awaiting requested review from racnan

Assignees

@Narayanbhat166 Narayanbhat166

Labels
A-core Area: Core flows C-refactor Category: Refactor
Projects
None yet
Milestone
October 2023 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Narayanbhat166 @SanchithHegde @ThisIsMani @Gnanasundari24