-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(connector): [Authorizedotnet]fix error deserialization incase of authentication failure #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tnet_fix Signed-off-by: chikke srujan <[email protected]>
srujanchikke
added
A-connector-integration
Area: Connector integration
C-bug
Category: Bug
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Oct 16, 2023
ArjunKarthik
previously approved these changes
Oct 16, 2023
prasunna09
previously approved these changes
Oct 16, 2023
ArjunKarthik
added
S-waiting-on-approval
Status: Review completed, awaiting for approvals from code-owners
and removed
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Oct 16, 2023
@srujanchikke ,Can you add the same testcases in the collection-dir. |
srujanchikke
dismissed stale reviews from prasunna09 and ArjunKarthik
via
October 17, 2023 11:01
6425761
ArjunKarthik
approved these changes
Oct 17, 2023
Gnanasundari24
approved these changes
Oct 17, 2023
likhinbopanna
approved these changes
Oct 17, 2023
SanchithHegde
approved these changes
Oct 17, 2023
SanchithHegde
removed
the
S-waiting-on-approval
Status: Review completed, awaiting for approvals from code-owners
label
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
fix error deserelization failure incase of authentication failure for authorizedotnet .
Additional Changes
Motivation and Context
fix error Deserelization incase of authentication failure
How did you test it?
Test cases :
1 ) Give wrong merchant account details while creating merchant connector account and make a payment . This should not throw 500 and error message should be
User authentication failed due to invalid authentication values.
2 ) If we give amount as 7002 cents ,the payment will fail with reason
This transaction has been declined.
.This step is just to verify error message working fine failed test cases3 ) Make a normal payment just to check payment flow is not broken because of this changes ( incase of authorizedotnet status would be processing , it takes 1 day to update).
postman testing
Checklist
cargo +nightly fmt --all
cargo clippy