Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [Authorizedotnet]fix error deserialization incase of authentication failure #2600

Merged
merged 5 commits into from
Oct 17, 2023

Conversation

srujanchikke
Copy link
Contributor

@srujanchikke srujanchikke commented Oct 16, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

fix error deserelization failure incase of authentication failure for authorizedotnet .

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

fix error Deserelization incase of authentication failure

How did you test it?

Test cases :
1 ) Give wrong merchant account details while creating merchant connector account and make a payment . This should not throw 500 and error message should be User authentication failed due to invalid authentication values.
2 ) If we give amount as 7002 cents ,the payment will fail with reason This transaction has been declined. .This step is just to verify error message working fine failed test cases
3 ) Make a normal payment just to check payment flow is not broken because of this changes ( incase of authorizedotnet status would be processing , it takes 1 day to update).

postman testing
Screenshot 2023-10-16 at 3 03 15 PM
Screenshot 2023-10-16 at 3 02 34 PM

Screenshot 2023-10-17 at 6 47 31 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@srujanchikke srujanchikke added A-connector-integration Area: Connector integration C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 16, 2023
@srujanchikke srujanchikke self-assigned this Oct 16, 2023
@srujanchikke srujanchikke requested a review from a team as a code owner October 16, 2023 10:04
ArjunKarthik
ArjunKarthik previously approved these changes Oct 16, 2023
prasunna09
prasunna09 previously approved these changes Oct 16, 2023
@ArjunKarthik ArjunKarthik added S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 16, 2023
@Gnanasundari24
Copy link
Contributor

@srujanchikke ,Can you add the same testcases in the collection-dir.

@srujanchikke srujanchikke dismissed stale reviews from prasunna09 and ArjunKarthik via 6425761 October 17, 2023 11:01
@srujanchikke srujanchikke requested a review from a team as a code owner October 17, 2023 11:01
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 17, 2023
@SanchithHegde SanchithHegde removed the S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners label Oct 17, 2023
Merged via the queue into main with commit 4859b7d Oct 17, 2023
11 checks passed
@Gnanasundari24 Gnanasundari24 deleted the authorizedotnet_fix branch October 17, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants