Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): replace temp locker with redis #2594

Merged
merged 12 commits into from
Oct 18, 2023
Merged

feat(core): replace temp locker with redis #2594

merged 12 commits into from
Oct 18, 2023

Conversation

Abhicodes-crypto
Copy link
Contributor

@Abhicodes-crypto Abhicodes-crypto commented Oct 15, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

In this PR,

  • The temp locker is replaced with Redis. Instead of storing data in temp locker the data would be stored in Redis.
  • Also inserting card in locker during payments confirmation is made asynchronous expect in the case of mandates.
  • There are legacy interfaces related to the temp locker like TokenizePayload and basilisk feature, such code will be eventually removed in subsequent PR's.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Test cases :

  • payments , Mandates , payment methods , list customer payment methods and any other flows which use temp locker need to work as expected.

Tested manually

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Abhicodes-crypto Abhicodes-crypto self-assigned this Oct 15, 2023
@Abhicodes-crypto Abhicodes-crypto requested review from a team as code owners October 15, 2023 13:45
SanchithHegde
SanchithHegde reviewed Oct 15, 2023
View reviewed changes
crates/router/src/configs/defaults.rs Outdated Show resolved Hide resolved
config/development.toml Outdated Show resolved Hide resolved
crates/router/src/configs/settings.rs Show resolved Hide resolved
@Abhicodes-crypto Abhicodes-crypto added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-configuration-changes Metadata: This PR involves configuration changes labels Oct 18, 2023
@Abhicodes-crypto Abhicodes-crypto removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 18, 2023
@Gnanasundari24
Copy link
Contributor

Gnanasundari24 commented Oct 18, 2023 •
edited by Abhicodes-crypto
Loading

@Abhicodes-crypto , Can you add the testcases.

@Abhicodes-crypto
Copy link
Contributor Author

@Gnanasundari24 added the test cases

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit 2edbd61 Oct 18, 2023
12 checks passed
@Gnanasundari24 Gnanasundari24 deleted the temp-locker-replace branch October 18, 2023 13:42
Abhicodes-crypto added a commit that referenced this pull request Oct 23, 2023
@Abhicodes-crypto
Revert "feat(core): replace temp locker with redis (#2594)"
0dd652c 
This reverts commit 2edbd61.
@Abhicodes-crypto Abhicodes-crypto mentioned this pull request Oct 23, 2023
Merged
15 tasks
@Abhicodes-crypto Abhicodes-crypto mentioned this pull request Nov 6, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnanasundari24 Gnanasundari24 Gnanasundari24 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@inventvenkat inventvenkat inventvenkat approved these changes

Assignees

@Abhicodes-crypto Abhicodes-crypto

Labels
A-core Area: Core flows M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Milestone
October 2023 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Abhicodes-crypto @Gnanasundari24 @inventvenkat @SanchithHegde