Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): [Authorizedotnet] Enhance currency Mapping with ConnectorCurrencyCommon Trait #2570

Merged
merged 7 commits into from
Oct 13, 2023
Merged

refactor(connector): [Authorizedotnet] Enhance currency Mapping with ConnectorCurrencyCommon Trait #2570

merged 7 commits into from
Oct 13, 2023

Conversation

Azanul
Copy link
Contributor

@Azanul Azanul commented Oct 12, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fixes #2218

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Azanul Azanul marked this pull request as ready for review October 13, 2023 05:52
@Azanul Azanul requested a review from a team as a code owner October 13, 2023 05:52
@srujanchikke srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 13, 2023
@Azanul Azanul marked this pull request as draft October 13, 2023 09:00
@Azanul
Copy link
Contributor Author

Azanul commented Oct 13, 2023

@srujanchikke Please ignore my review comments, I looked into it and have respectively fixed the issues.

@Azanul Azanul marked this pull request as ready for review October 13, 2023 09:09
@Azanul Azanul requested a review from srujanchikke October 13, 2023 09:09
srujanchikke
srujanchikke approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@srujanchikke srujanchikke added S-waiting-on-author Status: This PR is incomplete or needs to address review comments S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 13, 2023
SanchithHegde
SanchithHegde approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @Azanul!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 13, 2023
@SanchithHegde SanchithHegde removed the S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners label Oct 13, 2023
@SanchithHegde SanchithHegde added C-refactor Category: Refactor hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions labels Oct 13, 2023
Merged via the queue into juspay:main with commit d401975 Oct 13, 2023
@VedantKhairnar
Copy link
Contributor

Hey @Azanul 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@Azanul Azanul

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Authorizedotnet] Currency Unit Conversion
4 participants
@Azanul @VedantKhairnar @SanchithHegde @srujanchikke