Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(merchant_account): add merchant account list endpoint #2560

Merged
merged 11 commits into from
Oct 18, 2023

Conversation

Narayanbhat166
Copy link
Member

@Narayanbhat166 Narayanbhat166 commented Oct 12, 2023

Type of Change

  • New feature

Description

This will add the support for querying merchant accounts with a filter. Can be used by dependant crates

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

To allow list merchant accounts

How did you test it?

  • Create a merchant account - Note the org_id.
  • Call list merchant account with the above noted org_id
curl --location 'http://localhost:8080/accounts/list?organization_id=org_abcdefghijklmn' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data ''

Screenshot 2023-10-17 at 5 03 53 PM

Postman test results
Screenshot 2023-10-17 at 7 25 20 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@Narayanbhat166 Narayanbhat166 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 12, 2023
@Narayanbhat166 Narayanbhat166 added this to the October 2023 Milestone milestone Oct 12, 2023
@Narayanbhat166 Narayanbhat166 self-assigned this Oct 12, 2023
@Narayanbhat166 Narayanbhat166 requested a review from a team as a code owner October 12, 2023 08:59
@Narayanbhat166 Narayanbhat166 requested a review from a team as a code owner October 17, 2023 11:32
ThisIsMani
ThisIsMani previously approved these changes Oct 17, 2023
@Narayanbhat166 Narayanbhat166 changed the title feat(storage): add db query for merchant account list feat(merchant_account): add merchant account list endpoint Oct 17, 2023
racnan
racnan previously approved these changes Oct 17, 2023
@Narayanbhat166 Narayanbhat166 dismissed stale reviews from racnan and ThisIsMani via 54a34b4 October 17, 2023 13:54
@Narayanbhat166 Narayanbhat166 requested a review from a team as a code owner October 17, 2023 13:54
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Oct 18, 2023
Merged via the queue into main with commit a1472c6 Oct 18, 2023
11 checks passed
@Gnanasundari24 Gnanasundari24 deleted the merchant_account_list branch October 18, 2023 07:32
@SanchithHegde SanchithHegde added A-core Area: Core flows C-feature Category: Feature request or enhancement and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants