Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(postman): Added address update test cases #2555

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Conversation

likhinbopanna
Copy link
Contributor

@likhinbopanna likhinbopanna commented Oct 12, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Modify the existing Stripe postman collection (Hyperswitch collection) to add the address and amount update test cases

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Billing address and shipping address Update test cases was not present in the stripe collection .

How did you test it?

Ran the stripe collection

image (7)

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@likhinbopanna likhinbopanna requested a review from a team as a code owner October 12, 2023 07:26
@likhinbopanna likhinbopanna self-assigned this Oct 12, 2023
@likhinbopanna likhinbopanna added A-CI-CD Area: Continuous Integration/Deployment C-test Category: Tests labels Oct 12, 2023
@likhinbopanna likhinbopanna added this to the October 2023 Milestone milestone Oct 12, 2023
Gnanasundari24
Gnanasundari24 previously approved these changes Oct 12, 2023
},
{
"key": "publishable_key",
"value": "pk_snd_8798c6a9114646f8b970b93ad5765ddf",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty these values everywhere

},
"phone": {
"number": "8056594427",
"country_code": "+91"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert these changes

@@ -4,8 +4,6 @@
"API Key - Create",
"Payment Connector - Create",
"Payments - Create",
"Payment Connector - Update",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this was deleted?

@@ -44,7 +44,7 @@
"business_label": "default",
"connector_account_details": {
"auth_type": "HeaderKey",
"api_key": "{{connector_api_key}}_invalid_values"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've reverted all the changes that was made in this PR: #2531

Copy link
Member

@pixincreate pixincreate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 8a396a2 Oct 12, 2023
10 of 11 checks passed
@SanchithHegde SanchithHegde deleted the AddressUpdateTest branch October 12, 2023 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment C-test Category: Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants