Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [NexiNets] Update connector_response_reference_id as reference to merchant #2537

Merged
merged 1 commit into from
Oct 11, 2023
Merged

feat(connector): [NexiNets] Update connector_response_reference_id as reference to merchant #2537

merged 1 commit into from
Oct 11, 2023

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Oct 10, 2023 •
edited
Loading

Type of Change

  • New feature

Description

The connector_response_reference_id parameter has been set for the Nexi Nets Payment Solutions for uniform reference and transaction tracking.

File Changes

  • This PR modifies the Nexi Nets Transformers file.

Location- router/src/connector/nexinets/transformers.rs

Motivation and Context

This PR was raised so that it Fixes #2337

How did you test it?

  • I ran the following command, and all the errors were addressed properly, and the build was successful.
cargo clippy --all-features

build

  • The code changes were formatted with the following command to fix styling issues.
cargo +nightly fmt

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@Rutam21 Rutam21 requested a review from a team as a code owner October 10, 2023 14:22
@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 10, 2023 •
edited
Loading

@srujanchikke Please review and suggest changes, if any. Thanks.

CC: @AkshayaFoiger @prasunna09

@prasunna09
Copy link
Contributor

@Rutam21 Here the changes made and the issue you linked to this pr is related to connector_response_reference_id, hence changing the pr title.

@prasunna09 prasunna09 changed the title feat(connector): [Nexi Nets] Use connector_request_reference_id as re… feat(connector): [NexiNets] Update connector_response_reference_id as reference to merchant Oct 11, 2023
@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 11, 2023
@Rutam21
Copy link
Contributor Author

Rutam21 commented Oct 11, 2023

Thanks @prasunna09 for pointing that out. Let me know if it's ready to be merged or if any other changes are required.

srujanchikke
srujanchikke approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@prasunna09 prasunna09 added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 11, 2023
@ArjunKarthik
Copy link
Contributor

@Rutam21 Thanks for the PR

@ArjunKarthik ArjunKarthik added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions labels Oct 11, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Oct 11, 2023
Merged via the queue into juspay:main with commit 2f6c00a Oct 11, 2023
12 checks passed
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed S-ready-for-merge labels Oct 11, 2023
@VedantKhairnar
Copy link
Contributor

Hey @Rutam21 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@prasunna09 prasunna09 prasunna09 approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@Rutam21 Rutam21

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Nexi Nets] Use connector_response_reference_id as reference to merchant
6 participants
@Rutam21 @prasunna09 @ArjunKarthik @VedantKhairnar @srujanchikke @SanchithHegde