Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(worldline): use connector_request_reference_id as reference to the connector #2498

Merged
merged 7 commits into from
Oct 12, 2023
Merged

refactor(worldline): use connector_request_reference_id as reference to the connector #2498

merged 7 commits into from
Oct 12, 2023

Conversation

PanGan21
Copy link
Contributor

@PanGan21 PanGan21 commented Oct 8, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Replace payment_id with connector_request_reference_id in worldline.
Closes #2320

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@PanGan21 PanGan21 requested a review from a team as a code owner October 8, 2023 15:33
@prasunna09 prasunna09 added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 9, 2023
prasunna09
prasunna09 reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@prasunna09 prasunna09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PanGan21 Could you please go through the issue once again. The changes that you made are not expected . Please let us know if you need any help in understanding the problem .

@prasunna09 prasunna09 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 10, 2023
@PanGan21 PanGan21 marked this pull request as draft October 10, 2023 13:45
@PanGan21
Copy link
Contributor Author

@PanGan21 Could you please go through the issue once again. The changes that you made are not expected . Please let us know if you need any help in understanding the problem .

Thanks for checking. I was trying to compare it with #2052
I changed connector_response_reference_id to use connector_request_reference_id instead. Let me know if that was meant from the issue or I misunderstood it

@PanGan21 PanGan21 requested a review from prasunna09 October 11, 2023 07:47
@PanGan21 PanGan21 marked this pull request as ready for review October 11, 2023 20:11
@srujanchikke
Copy link
Contributor

@PanGan21 Could you please go through the issue once again. The changes that you made are not expected . Please let us know if you need any help in understanding the problem .

Thanks for checking. I was trying to compare it with #2052 I changed connector_response_reference_id to use connector_request_reference_id instead. Let me know if that was meant from the issue or I misunderstood it

Hi @PanGan21 ,

The issue mentions that merchant reference id field from connector request(need to check in world line documentation ) should be set to connector_request_reference_id . Please let us know if you have any other queries

@PanGan21 PanGan21 marked this pull request as draft October 12, 2023 10:08
@PanGan21 PanGan21 marked this pull request as ready for review October 12, 2023 11:12
srujanchikke
srujanchikke approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@srujanchikke srujanchikke added S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 12, 2023
SanchithHegde
SanchithHegde approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @PanGan21!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 12, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners labels Oct 12, 2023
Merged via the queue into juspay:main with commit efa5320 Oct 12, 2023
@VedantKhairnar
Copy link
Contributor

Hey @PanGan21 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@prasunna09 prasunna09 Awaiting requested review from prasunna09

Assignees

@PanGan21 PanGan21

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Worldline] Use connector_request_reference_id as reference to the connector
5 participants
@PanGan21 @srujanchikke @VedantKhairnar @SanchithHegde @prasunna09