refactor(connector): Use connector_response_reference_id for Shift4 #2492

daniloff200 · 2023-10-08T00:13:23Z

Type of Change

Description

fixes #2316

Additional Changes

This PR modifies the API contract
This PR modifies the database schema
This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

I formatted the code cargo +nightly fmt --all
I addressed lints thrown by cargo clippy
I reviewed the submitted code
I added unit tests for my changes where possible
I added a CHANGELOG entry if applicable

srujanchikke · 2023-10-08T12:54:39Z

Hey @daniloff200 ,

Please use the following cargo command -

cargo clippy --all-features

ref - Cargo commands, and fix the errors thrown by clippy for the checks to pass .

Please run cargo +nightly fmt to fix failing formatting check

daniloff200 · 2023-10-08T13:27:03Z

hi, @srujanchikke . Thanks for your review! I've executed the commands

daniloff200 · 2023-10-10T19:47:07Z

hi, @srujanchikke , could you help me with an issue, I have here? I've tried various fixes, but, got a problem with a Some (as here -> https://github.com/juspay/hyperswitch/actions/runs/6459469231/job/17538567259?pr=2492) or with borrowed value.
I'm kinda new to Rust, and tried different approaches, but, it doesn't work

srujanchikke

As this PR addressing #2347 , i am reassigning the issue , So could you please comment on this issue #2347

srujanchikke · 2023-10-19T06:05:27Z

crates/router/src/connector/shift4/transformers.rs

@@ -671,6 +671,8 @@ impl<F>
            types::PaymentsResponseData,
        >,
    ) -> Result<Self, Self::Error> {
+        let token_id = types::ResponseId::ConnectorTransactionId(item.response.token.id.clone());


Shift4ThreeDsResponse don't have field id , Remove token_id

srujanchikke · 2023-10-19T06:05:43Z

crates/router/src/connector/shift4/transformers.rs

@@ -686,7 +688,7 @@ impl<F>
                ..item.data.request
            },
            response: Ok(types::PaymentsResponseData::TransactionResponse {
-                resource_id: types::ResponseId::NoResponseId,
+                resource_id: token_id,


Revert this change too

daniloff200 · 2023-10-20T21:43:50Z

@srujanchikke can you review my pr please? I've managed to fix all issues

srujanchikke

minor changes required , other than that looks good to me !

srujanchikke · 2023-10-21T05:20:12Z

crates/router/src/connector/shift4/transformers.rs

@@ -671,6 +671,7 @@ impl<F>
            types::PaymentsResponseData,
        >,
    ) -> Result<Self, Self::Error> {
+        let token_id = Some(item.response.token.id.clone());


This token id is not connector response id , it is shift4 3ds token id . revert the changes from shift4 try_from .

srujanchikke

LGTM

SanchithHegde

Looks good to me!

Thanks for the PR, @daniloff200!

swangi-kumari · 2023-10-23T11:33:57Z

Hey @daniloff200 ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

daniloff200 · 2023-10-23T13:14:06Z

@swangi-kumari hey!
Thanks for the link, I've submitted the form. One question: can it be the issue, if I live in Ukraine?
because previous year, for example, the Digital Ocean were not shipping swag here, because of the military actions here

VedantKhairnar · 2023-10-26T06:14:09Z

Hey @daniloff200 ,
We are using DHL courier service and they do provide service in Ukraine as shown in the above image.
If we face any issues, we will reach out to you. If you have any queries, pls let us know.
Thanks.

daniloff200 requested a review from a team as a code owner October 8, 2023 00:13

github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 8, 2023

daniloff200 force-pushed the fix-2316 branch 3 times, most recently from 5a0dc69 to 966fdea Compare October 8, 2023 11:55

daniloff200 changed the title ~~Use connector_request_reference_id as reference to the connector for …~~ refactor(connector): Use connector_request_reference_id for Shift4 Oct 8, 2023

github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 8, 2023

daniloff200 force-pushed the fix-2316 branch 3 times, most recently from 4285b57 to f011034 Compare October 8, 2023 12:44

srujanchikke assigned daniloff200 Oct 8, 2023

srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 8, 2023

daniloff200 force-pushed the fix-2316 branch 2 times, most recently from 3cedd88 to a270a9d Compare October 8, 2023 13:24

daniloff200 force-pushed the fix-2316 branch 10 times, most recently from 0da02d6 to 71ccad7 Compare October 10, 2023 19:41

daniloff200 force-pushed the fix-2316 branch 3 times, most recently from 2f91fec to 7fc6db9 Compare October 18, 2023 17:59

srujanchikke requested changes Oct 19, 2023

View reviewed changes

srujanchikke changed the title ~~refactor(connector): Use connector_request_reference_id for Shift4~~ refactor(connector): Use connector_response_reference_id for Shift4 Oct 19, 2023

daniloff200 force-pushed the fix-2316 branch 6 times, most recently from 20a28dd to 408a75a Compare October 20, 2023 09:12

srujanchikke requested changes Oct 21, 2023

View reviewed changes

refactor(connector): Use connector_request_reference_id for Shift4

8d440b0

daniloff200 force-pushed the fix-2316 branch from 2530616 to 8d440b0 Compare October 21, 2023 10:52

srujanchikke approved these changes Oct 21, 2023

View reviewed changes

SanchithHegde approved these changes Oct 21, 2023

View reviewed changes

SanchithHegde added this pull request to the merge queue Oct 21, 2023

SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 21, 2023

Merged via the queue into juspay:main with commit 83f0062 Oct 21, 2023
10 checks passed

daniloff200 deleted the fix-2316 branch October 21, 2023 12:47

SanchithHegde linked an issue Oct 22, 2023 that may be closed by this pull request

[FEATURE]: [Shift4] Use connector_response_reference_id as reference to merchant #2347

Closed

2 tasks

SanchithHegde mentioned this pull request Oct 22, 2023

[FEATURE]: [Shift4] Use connector_response_reference_id as reference to merchant #2347

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(connector): Use connector_response_reference_id for Shift4 #2492

refactor(connector): Use connector_response_reference_id for Shift4 #2492

daniloff200 commented Oct 8, 2023 •

edited

Loading

srujanchikke commented Oct 8, 2023 •

edited

Loading

daniloff200 commented Oct 8, 2023

daniloff200 commented Oct 10, 2023

srujanchikke left a comment •

edited

Loading

srujanchikke Oct 19, 2023

srujanchikke Oct 19, 2023

daniloff200 commented Oct 20, 2023

srujanchikke left a comment

srujanchikke Oct 21, 2023

srujanchikke left a comment

SanchithHegde left a comment

swangi-kumari commented Oct 23, 2023

daniloff200 commented Oct 23, 2023 •

edited

Loading

VedantKhairnar commented Oct 26, 2023

refactor(connector): Use connector_response_reference_id for Shift4 #2492

refactor(connector): Use connector_response_reference_id for Shift4 #2492

Conversation

daniloff200 commented Oct 8, 2023 • edited Loading

Type of Change

Description

Additional Changes

Motivation and Context

How did you test it?

Checklist

srujanchikke commented Oct 8, 2023 • edited Loading

daniloff200 commented Oct 8, 2023

daniloff200 commented Oct 10, 2023

srujanchikke left a comment • edited Loading

Choose a reason for hiding this comment

srujanchikke Oct 19, 2023

Choose a reason for hiding this comment

srujanchikke Oct 19, 2023

Choose a reason for hiding this comment

daniloff200 commented Oct 20, 2023

srujanchikke left a comment

Choose a reason for hiding this comment

srujanchikke Oct 21, 2023

Choose a reason for hiding this comment

srujanchikke left a comment

Choose a reason for hiding this comment

SanchithHegde left a comment

Choose a reason for hiding this comment

swangi-kumari commented Oct 23, 2023

daniloff200 commented Oct 23, 2023 • edited Loading

VedantKhairnar commented Oct 26, 2023

daniloff200 commented Oct 8, 2023 •

edited

Loading

srujanchikke commented Oct 8, 2023 •

edited

Loading

srujanchikke left a comment •

edited

Loading

daniloff200 commented Oct 23, 2023 •

edited

Loading