Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Auto generate the OpenAPI spec if Validate generated OpenAPI spec file check fails #2471

Merged
merged 34 commits into from
Oct 10, 2023
Merged

CI: Auto generate the OpenAPI spec if Validate generated OpenAPI spec file check fails #2471

merged 34 commits into from
Oct 10, 2023

Conversation

ShankarSinghC
Copy link
Contributor

@ShankarSinghC ShankarSinghC commented Oct 5, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Auto generate the OpenAPI Spec when Validate Generated OpenAPI Spec File check fails

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@ShankarSinghC ShankarSinghC added the A-CI-CD Area: Continuous Integration/Deployment label Oct 5, 2023
@ShankarSinghC ShankarSinghC self-assigned this Oct 5, 2023
@ShankarSinghC ShankarSinghC requested review from a team as code owners October 5, 2023 19:33
@ShankarSinghC ShankarSinghC requested a review from a team as a code owner October 6, 2023 06:59
github-actions bot and others added 18 commits October 6, 2023 06:59
@github-actions
chore: run formatter
3efaaab
@ShankarSinghC
Merge branch 'main' of https://github.com/juspay/hyperswitch into aut…
5fa351a 
…o-generate-openapi_spec
@ShankarSinghC
Merge branch 'auto-generate-openapi_spec' of https://github.com/juspa…
572db94 
…y/hyperswitch into auto-generate-openapi_spec
@ShankarSinghC
use token for formatting
003a2e5
@github-actions
chore: run formatter
e6de124
@ShankarSinghC
use token to test auto generate the openapi spec
d522bba
@github-actions
docs(openapi): re-generate OpenAPI specification
93ac67e
@ShankarSinghC
Merge branch 'main' of https://github.com/juspay/hyperswitch into aut…
cc6c31b 
…o-generate-openapi_spec
@ShankarSinghC
merge main
80414ee
@ShankarSinghC
test commit
431a651
@github-actions
docs(openapi): re-generate OpenAPI specification
db2fc61
@ShankarSinghC
test the repo name check
a06a7c7
@ShankarSinghC
test auto generating OpenApi Spec
0c9fc60
@ShankarSinghC
have different checkout for prs from external contributers
716e7ed
@ShankarSinghC
Merge branch 'main' of https://github.com/juspay/hyperswitch into aut…
4df33ef 
…o-generate-openapi_spec
@github-actions
docs(openapi): re-generate OpenAPI specification
dfe169c
@ShankarSinghC
Merge branch 'auto-generate-openapi_spec' of https://github.com/juspa…
58b6c46 
…y/hyperswitch into auto-generate-openapi_spec
@ShankarSinghC
have a check during checkout pr
a5acbc5
@ShankarSinghC ShankarSinghC added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 9, 2023
SanchithHegde
SanchithHegde reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

.github/workflows/validate-openapi-spec.yml Show resolved Hide resolved
Chethan-rao
Chethan-rao previously approved these changes Oct 9, 2023
View reviewed changes
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 10, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 10, 2023
Merged via the queue into main with commit ec7acd1 Oct 10, 2023
10 checks passed
@SanchithHegde SanchithHegde deleted the auto-generate-openapi_spec branch October 10, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chethan-rao Chethan-rao Chethan-rao approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@ShankarSinghC ShankarSinghC

Labels
A-CI-CD Area: Continuous Integration/Deployment
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShankarSinghC @SanchithHegde @Chethan-rao