Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Cybersource] Use connector_response_reference_id as reference to merchant #2470

Merged
merged 13 commits into from
Oct 7, 2023
Merged

feat(connector): [Cybersource] Use connector_response_reference_id as reference to merchant #2470

merged 13 commits into from
Oct 7, 2023

Conversation

rashmibharambe
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Use connector_response_reference_id as reference to merchant for Cybersource
Fixes #2327

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

fixes #2327

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

rashmibharambe and others added 10 commits October 5, 2023 23:16
@rashmibharambe
feat(connector): [Cybersource] Use connector_response_reference_id as…
ac0ff51 
… reference to merchant
@rashmibharambe
feat(connector): [Cybersource] Use connector_response_reference_id as…
6b2e921 
… reference to merchant
@github-actions
chore: run formatter
61a61df
@rashmibharambe
feat(connector): [Cybersource] Use connector_response_reference_id as…
b6acef3 
… reference
@rashmibharambe
feat(connector): [Cybersource] Use connector_response_reference_id as…
954cce6 
… reference to merchant
@rashmibharambe
feat(connector): [Cybersource] Use connector_response_reference_id as…
a0bba63 
… reference to merchant
@rashmibharambe
feat(cybersource): [Cybersource] Use connector_response_reference_id …
3426077 
…as reference to merchant
@rashmibharambe
feat(connector): [PayU] Use connector_response_response_id as reference
0b2061d
@rashmibharambe
feat(connector): [PayU] Use connector_response_response_id as reference
7ff9e74
@github-actions
chore: run formatter
b878e2a
@SanchithHegde
Copy link
Member

@rashmibharambe Could you merge the main branch into your PR?

@rashmibharambe rashmibharambe marked this pull request as ready for review October 6, 2023 01:56
@rashmibharambe rashmibharambe requested a review from a team as a code owner October 6, 2023 01:56
@rashmibharambe
Copy link
Contributor Author

@rashmibharambe Could you merge the main branch into your PR?

Done, please review.

@srujanchikke srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 6, 2023
@srujanchikke srujanchikke added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 6, 2023
@rashmibharambe
Copy link
Contributor Author

@srujanchikke - please review, comments addressed..

srujanchikke
srujanchikke approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@srujanchikke srujanchikke added S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 7, 2023
@ArjunKarthik ArjunKarthik added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 7, 2023
@ArjunKarthik
Copy link
Contributor

@rashmibharambe Thanks for the PR

@ArjunKarthik ArjunKarthik added this pull request to the merge queue Oct 7, 2023
Merged via the queue into juspay:main with commit a2dfc48 Oct 7, 2023
@SanchithHegde SanchithHegde removed the S-waiting-on-approval Status: Review completed, awaiting for approvals from code-owners label Oct 7, 2023
@rashmibharambe rashmibharambe deleted the patch-1 branch October 8, 2023 17:51
@VedantKhairnar
Copy link
Contributor

Hey @rashmibharambe 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@rashmibharambe rashmibharambe

Labels
A-connector-integration Area: Connector integration hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Cybersource] Use connector_response_reference_id as reference to merchant
5 participants
@rashmibharambe @SanchithHegde @ArjunKarthik @VedantKhairnar @srujanchikke