Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Noon] Use connector_request_reference_id as Order reference #2466

Merged
merged 1 commit into from
Oct 6, 2023
Merged

feat(connector): [Noon] Use connector_request_reference_id as Order reference #2466

merged 1 commit into from
Oct 6, 2023

Conversation

daniel-shuy
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Closes #2308

Use connector_request_reference_id instead of payment_id as Order reference

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@daniel-shuy daniel-shuy requested a review from a team as a code owner October 5, 2023 17:35
@srujanchikke srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 5, 2023
@srujanchikke srujanchikke removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 5, 2023
SanchithHegde
SanchithHegde approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @daniel-shuy!

By the way, could you please comment on #2308 that you've opened a PR for the same, so that we can assign it to you and no one else would take it up?

@daniel-shuy daniel-shuy mentioned this pull request Oct 6, 2023
Closed
2 tasks
@daniel-shuy
Copy link
Contributor Author

@SanchithHegde Done, thanks!

@daniel-shuy daniel-shuy force-pushed the noon-request-reference-id branch from 8ccb1d4 to 2fc3b6d Compare October 6, 2023 06:07
@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 6, 2023
@SanchithHegde SanchithHegde added C-feature Category: Feature request or enhancement hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions labels Oct 6, 2023
Merged via the queue into juspay:main with commit 2897b6e Oct 6, 2023
10 checks passed
@VedantKhairnar
Copy link
Contributor

Hey @daniel-shuy 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@daniel-shuy daniel-shuy deleted the noon-request-reference-id branch October 7, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@daniel-shuy daniel-shuy

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Noon] Use connector_request_reference_id as reference to the connector
4 participants
@daniel-shuy @VedantKhairnar @SanchithHegde @srujanchikke