feat(router): add mandates incoming webhooks flow #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-core
jarnura
requested changes
Oct 5, 2023
crates/router/src/core/webhooks.rs
Outdated
| db.update_payment_attempt_with_attempt_id( | ||
| payment_attempt, | ||
| storage::PaymentAttemptUpdate::StatusUpdate { | ||
| status: api_models::enums::AttemptStatus::Charged, |
There was a problem hiding this comment.
Why we are hard coding this as succeeded, this should be derived from mandate status.
jarnura
approved these changes
Oct 5, 2023
ArjunKarthik
approved these changes
Oct 5, 2023
ArjunKarthik
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add mandates incoming webhooks flow
Additional Changes
Motivation and Context
How did you test it?
Original payment id being stored in mandate record
Mandates webhook flow
Compiler guided
Checklist
cargo +nightly fmt --allcargo clippy