Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [PayU] Use connector_response_response_id as reference to merchant #2452

Merged
merged 15 commits into from
Oct 5, 2023
Merged

feat(connector): [PayU] Use connector_response_response_id as reference to merchant #2452

merged 15 commits into from
Oct 5, 2023

Conversation

harshalkh
Copy link
Contributor

@harshalkh harshalkh commented Oct 4, 2023 •
edited by srujanchikke
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Fixes #2344

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fixes #2344

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@harshalkh harshalkh requested a review from a team as a code owner October 4, 2023 16:32
@harshalkh harshalkh mentioned this pull request Oct 4, 2023
Closed
2 tasks
@srujanchikke srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 4, 2023
@harshalkh
Copy link
Contributor Author

@srujanchikke I have done required changes, do I need to use clone as well here? Or not required?

@srujanchikke
Copy link
Contributor

@srujanchikke I have done required changes, do I need to use clone as well here? Or not required?

Yes , you need to use clone here

resource_id: types::ResponseId::ConnectorTransactionId(item.response.order_id.clone()),

@srujanchikke
Copy link
Contributor

Hey @harshalkh ,

Please use the following cargo commands -

cargo check --all-features
cargo clippy --all-features

ref - Cargo commands, and fix the errors thrown by clippy for the checks to pass .

Please run cargo +nightly fmt to fix failing formatting check

@harshalkh
Copy link
Contributor Author

Hey @harshalkh ,

Please use the following cargo commands -

cargo check --all-features cargo clippy --all-features

ref - Cargo commands, and fix the errors thrown by clippy for the checks to pass .

Please run cargo +nightly fmt to fix failing formatting check

Thanks I will check

@srujanchikke srujanchikke added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 5, 2023
@harshalkh harshalkh closed this Oct 5, 2023
@harshalkh harshalkh reopened this Oct 5, 2023
srujanchikke
srujanchikke approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

SanchithHegde
SanchithHegde approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @harshalkh!

@SanchithHegde SanchithHegde changed the title feat(connector): [PayU] Use connector_response_response_id as referen… feat(connector): [PayU] Use connector_response_response_id as reference to merchant Oct 5, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 5, 2023
@SanchithHegde SanchithHegde added C-feature Category: Feature request or enhancement hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 5, 2023
Merged via the queue into juspay:main with commit e24897c Oct 5, 2023
11 checks passed
@VedantKhairnar
Copy link
Contributor

Hey @harshalkh 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@harshalkh harshalkh deleted the patch-1 branch October 8, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@harshalkh harshalkh

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [PayU] Use connector_response_reference_id as reference to merchant
4 participants
@harshalkh @srujanchikke @VedantKhairnar @SanchithHegde