Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Multisafepay] Use transaction_id as reference to transaction #2451

Merged
merged 12 commits into from
Oct 7, 2023
Merged

feat(connector): [Multisafepay] Use transaction_id as reference to transaction #2451

merged 12 commits into from
Oct 7, 2023

Conversation

nabeel001
Copy link
Contributor

@nabeel001 nabeel001 commented Oct 4, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Updated the connector_response_reference_id value from the response.
closes #2336

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  • Reference id are used to map transactions in the connector’s dashboard.
  • Hyperswitch manages several reference ids, such as payment_id, attempt_id, and connector_transaction_id for a single transaction.
  • However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@nabeel001 nabeel001 requested a review from a team as a code owner October 4, 2023 16:17
@nabeel001 nabeel001 mentioned this pull request Oct 4, 2023
Closed
2 tasks
srujanchikke
srujanchikke reviewed Oct 4, 2023
View reviewed changes
crates/router/src/connector/multisafepay/transformers.rs Outdated
@@ -543,7 +543,7 @@ impl<F, T>
}),
connector_metadata: None,
network_txn_id: None,
connector_response_reference_id: None,
connector_response_reference_id: item.response.data.transaction_id,
Copy link
Contributor

@srujanchikke srujanchikke Oct 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nabeel001 ,

As per api docs of multisafepay , order_id is merchant_refernece_id which should be mapped to connector_response_reference_id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srujanchikke
I had misunderstood the issue's requirement and mapped the transaction_id directly from the response.
Thanks for pointing it out, I'll make the required change.

image

@srujanchikke
Copy link
Contributor

Hello @nabeel001

Please use following cargo commands -

cargo check --all-features
cargo clippy --all-features
ref - Cargo commands, and fix the errors thrown by clippy for the checks to pass .

@srujanchikke srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-author Status: This PR is incomplete or needs to address review comments hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 5, 2023
@srujanchikke
Copy link
Contributor

Hey @nabeel001 ,

Please update the branch !

@VedantKhairnar
Copy link
Contributor

Hey @nabeel001 ,
Let us know if you face any issues. Happy to help! : )

@nabeel001
Copy link
Contributor Author

@srujanchikke @VedantKhairnar I have updated the code and all the tests are passing too.
kindly review and merge.

@nabeel001 nabeel001 requested a review from srujanchikke October 7, 2023 07:33
srujanchikke
srujanchikke approved these changes Oct 7, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

SanchithHegde
SanchithHegde approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @nabeel001!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 7, 2023
@SanchithHegde SanchithHegde added C-feature Category: Feature request or enhancement hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 7, 2023
Merged via the queue into juspay:main with commit ba2efac Oct 7, 2023
10 checks passed
@VedantKhairnar
Copy link
Contributor

Hey @nabeel001 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@nabeel001
Copy link
Contributor Author

@VedantKhairnar
I have filled the google form using another mail Id that is not associated with my GitHub account. Is that fine or should I submit another response with the mail id that is linked to my Github account?
can u pls confirm this..

@VedantKhairnar
Copy link
Contributor

That's fine @nabeel001 .
You don't need to refill.
.
Thanks for your contribution! : )

@nabeel001
Copy link
Contributor Author

@VedantKhairnar Any Idea when will I be receiving my swag, I'm asking because I haven't received any mail about it either.

@VedantKhairnar
Copy link
Contributor

Hey @nabeel001
Printing and shipping is in process. Some of them are shipped. It might take around a week more.
Thanks for your patience. Let us know if you have any other queries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@nabeel001 nabeel001

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Multisafepay] Use connector_response_reference_id as reference to merchant
4 participants
@nabeel001 @srujanchikke @VedantKhairnar @SanchithHegde