-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector): [Dlocal] Use connector_response_reference_id as reference to merchant #2446
Conversation
…rence to merchant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SargamPuram ,
As per Dlocal Api documentation order_id
is merchant reference in payment response.
Hey @srujanchikke I apologize for the blunder . I thought we had to populate it with payment-specific ID in their response to the payment . I had discussed while getting the issue assigned too . But yes I'll make the changes. |
Hi @SargamPuram
ref - https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md#cargo-commands, and fix the errors thrown by clippy for the checks to pass Please run |
yes, I'll to run those commands. Actually , I'm having my university papers from tomorrow, I'll be done with them by next Friday. Is that okay if i look into it then? 😅 |
Sure @SargamPuram , Please feel free to reach out to us if you have any further queries. We would be happy to help you out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks for the PR, @SargamPuram!
Hey @SargamPuram 👋, |
Type of Change
Description
I have populated the 'id' which is provided as a payment-specific ID in their response to then be populated as 'connector_reference_id'. As per the docs they don't require a payment reference ID in their payment requests. So populated the existing id.
Additional Changes
Motivation and Context
If it fixes an open issue, please link to the issue here.
It fixes an open issue . Closes #2328
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy