Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [Dlocal] Use connector_response_reference_id as reference to merchant #2446

Merged
merged 9 commits into from
Oct 15, 2023

Conversation

SargamPuram
Copy link
Contributor

Type of Change

  • Bugfix
  • [x ] New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

I have populated the 'id' which is provided as a payment-specific ID in their response to then be populated as 'connector_reference_id'. As per the docs they don't require a payment reference ID in their payment requests. So populated the existing id.
dlocal1

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

If it fixes an open issue, please link to the issue here.
It fixes an open issue . Closes #2328

How did you test it?

Checklist

  • [x ] I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • [x ] I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SargamPuram SargamPuram requested a review from a team as a code owner October 4, 2023 11:16
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SargamPuram ,

As per Dlocal Api documentation order_id is merchant reference in payment response.

@SargamPuram
Copy link
Contributor Author

Hi @SargamPuram ,

As per Dlocal Api documentation order_id is merchant reference in payment response.

Hey @srujanchikke I apologize for the blunder . I thought we had to populate it with payment-specific ID in their response to the payment . I had discussed while getting the issue assigned too . But yes I'll make the changes.

@srujanchikke srujanchikke requested a review from a team October 4, 2023 13:31
@srujanchikke srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-author Status: This PR is incomplete or needs to address review comments hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Oct 4, 2023
@prasunna09
Copy link
Contributor

Hi @SargamPuram
Please use following cargo commands -

cargo check --all-features                                                                  
cargo clippy --all-features

ref - https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md#cargo-commands, and fix the errors thrown by clippy for the checks to pass

Please run cargo +nightly fmt to fix failing formatting check

@SargamPuram
Copy link
Contributor Author

SargamPuram commented Oct 4, 2023

yes, I'll to run those commands. Actually , I'm having my university papers from tomorrow, I'll be done with them by next Friday. Is that okay if i look into it then? 😅

@srujanchikke
Copy link
Contributor

yes, I'll to run those commands. Actually , I'm having my university papers from tomorrow, I'll be done with them by next Friday. Is that okay if i look into it then? 😅

Sure @SargamPuram ,

Please feel free to reach out to us if you have any further queries. We would be happy to help you out!

@SanchithHegde SanchithHegde added C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 15, 2023
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @SargamPuram!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 15, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 15, 2023
Merged via the queue into juspay:main with commit f6677b8 Oct 15, 2023
10 checks passed
@VedantKhairnar
Copy link
Contributor

Hey @SargamPuram 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Dlocal] Use connector_response_reference_id as reference to merchant
5 participants