Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Noon] Use connector_response_reference_id as reference #2442

Merged
merged 5 commits into from
Oct 4, 2023
Merged

feat(connector): [Noon] Use connector_response_reference_id as reference #2442

merged 5 commits into from
Oct 4, 2023

Conversation

sudharsangs
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

I have added reference that's sent to noon payments order to the TransactionResponse in transformer.rs of noon that's present in the connector directory.

https://github.com/juspay/hyperswitch/blob/main/crates/router/src/connector/noon/transformers.rs

Motivation and Context

Closes #2339

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sudharsangs sudharsangs requested a review from a team as a code owner October 4, 2023 10:01
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 4, 2023
@sudharsangs sudharsangs changed the title feat(connector):[Noon] Use connector_response_reference_id as referece feat(connector): [Noon] Use connector_response_reference_id as reference Oct 4, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 4, 2023
@srujanchikke srujanchikke requested a review from a team October 4, 2023 10:26
@srujanchikke srujanchikke added A-connector-integration Area: Connector integration hacktoberfest Issues that are up for grabs for Hacktoberfest participants S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 4, 2023
srujanchikke
srujanchikke previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

SanchithHegde
SanchithHegde approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @sudharsangs!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 4, 2023
@SanchithHegde SanchithHegde added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions C-feature Category: Feature request or enhancement and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels Oct 4, 2023
Merged via the queue into juspay:main with commit 688557e Oct 4, 2023
@VedantKhairnar
Copy link
Contributor

Hey @sudharsangs 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@sudharsangs sudharsangs

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Noon] Use connector_response_reference_id as reference to merchant
5 participants
@sudharsangs @VedantKhairnar @SanchithHegde @SamraatBansal @srujanchikke