Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Square] Use reference_id as reference to merchant #2434

Merged
merged 2 commits into from
Oct 4, 2023
Merged

feat(connector): [Square] Use reference_id as reference to merchant #2434

merged 2 commits into from
Oct 4, 2023

Conversation

VedantKhairnar
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Populated reference ID from the response

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

  • Reference id are used to map transactions in the connector’s dashboard.
  • Hyperswitch manages several reference ids, such as payment_id, attempt_id, and connector_transaction_id for a single transaction.
  • However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@VedantKhairnar VedantKhairnar requested a review from a team as a code owner October 3, 2023 14:40
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 3, 2023
@VedantKhairnar VedantKhairnar changed the title feat(connector):[Square] Use connector_response_reference_id as reference to merchant feat(connector):[Square] Use reference_id as reference to merchant Oct 3, 2023
@VedantKhairnar VedantKhairnar linked an issue Oct 3, 2023 that may be closed by this pull request
[FEATURE]: [Square] Use connector_response_reference_id as reference to merchant #2349
Closed
2 tasks
@srujanchikke srujanchikke changed the title feat(connector):[Square] Use reference_id as reference to merchant feat(connector): [Square] Use reference_id as reference to merchant Oct 4, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Oct 4, 2023
@srujanchikke srujanchikke added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 4, 2023
srujanchikke
srujanchikke approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@srujanchikke srujanchikke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@srujanchikke srujanchikke added the hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Oct 4, 2023
@ArjunKarthik ArjunKarthik added hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 4, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Oct 4, 2023
Merged via the queue into juspay:main with commit 591c9b7 Oct 4, 2023
10 of 12 checks passed
@swangi-kumari
Copy link
Contributor

Hey @VedantKhairnar ,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

@VedantKhairnar VedantKhairnar deleted the square-reference-id branch November 17, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@VedantKhairnar VedantKhairnar

Labels
A-connector-integration Area: Connector integration hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Square] Use connector_response_reference_id as reference to merchant
4 participants
@VedantKhairnar @swangi-kumari @ArjunKarthik @srujanchikke