Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use key_mode based on env and update description #2428

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: use key_mode based on env and update description #2428

merged 1 commit into from
Oct 3, 2023

Conversation

SamraatBansal
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

use key_mode based on env and update description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-09-27 at 5 32 15 PM Screenshot 2023-09-27 at 5 33 04 PM Screenshot 2023-09-27 at 5 33 18 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@SamraatBansal SamraatBansal added A-connector-integration Area: Connector integration C-bug Category: Bug P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed M-configuration-changes Metadata: This PR involves configuration changes labels Oct 3, 2023
@SamraatBansal SamraatBansal requested a review from a team as a code owner October 3, 2023 12:53
@SamraatBansal SamraatBansal self-assigned this Oct 3, 2023
@SamraatBansal SamraatBansal requested a review from a team as a code owner October 3, 2023 12:53
@SanchithHegde SanchithHegde merged commit 3b969c3 into hotfix-1.44.0 Oct 3, 2023
9 of 10 checks passed
@SanchithHegde SanchithHegde deleted the fix/noon-prod-env branch October 3, 2023 13:17
@SanchithHegde SanchithHegde removed P-high Priority: High S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 3, 2023
shakthi-22
shakthi-22 reviewed Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@shakthi-22 shakthi-22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shakthi-22 shakthi-22 shakthi-22 left review comments

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@SamraatBansal SamraatBansal

Labels
A-connector-integration Area: Connector integration C-bug Category: Bug M-configuration-changes Metadata: This PR involves configuration changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SamraatBansal @ArjunKarthik @SanchithHegde @Narayanbhat166 @shakthi-22