Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [Nuvei] Add order id as the reference id #2408

Merged
merged 1 commit into from
Oct 2, 2023
Merged

feat(connector): [Nuvei] Add order id as the reference id #2408

merged 1 commit into from
Oct 2, 2023

Conversation

Ceres445
Copy link
Contributor

@Ceres445 Ceres445 commented Oct 1, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Nuvei is using just the order id to track the transaction.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Closes #2340

How did you test it?

I wasn't able to test it on my machine due to ram restrictions.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Ceres445 Ceres445 requested a review from a team as a code owner October 1, 2023 18:46
@SanchithHegde
Copy link
Member

Hey @Ceres445, could you please comment on #2340 that you've opened a PR for it, and we will assign that issue to you? This would prevent other contributors from taking it up, unaware of the fact that there's already an open PR for the same.

@SanchithHegde SanchithHegde added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions labels Oct 1, 2023
@SanchithHegde SanchithHegde changed the title feat(connector): [Nuvei] Add order id as the reference id (#2340) feat(connector): [Nuvei] Add order id as the reference id Oct 1, 2023
SanchithHegde
SanchithHegde approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks for the PR, @Ceres445!

@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 2, 2023
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 2, 2023
Merged via the queue into juspay:main with commit d5d876b Oct 2, 2023
11 checks passed
@VedantKhairnar
Copy link
Contributor

Hey @Ceres445 👋,
Thanks a bunch for all your contributions! We've got a little something for you to show our appreciation.
Just take a moment to fill out this form, and get ready for some awesome swag coming your way.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@Ceres445 Ceres445

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: [Nuvei] Use connector_response_reference_id as reference to merchant
4 participants
@Ceres445 @SanchithHegde @VedantKhairnar @ArjunKarthik