Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update actions/checkout to v4 #2406

Closed
wants to merge 1 commit into from
Closed

ci: update actions/checkout to v4 #2406

wants to merge 1 commit into from

Conversation

Sushrut1101
Copy link

No description provided.

@Sushrut1101 Sushrut1101 requested a review from a team as a code owner October 1, 2023 16:52
@SanchithHegde SanchithHegde added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions labels Oct 1, 2023
@SanchithHegde
Copy link
Member

Hey @Sushrut1101, thanks for the PR!

If you don't mind, could you also update the other actions to their latest versions?

Please note the convention we've followed for pinning versions of actions:

  • Official GitHub and Docker actions (say actions/checkout and docker/build-push-action) would be specified only by their major versions (v3 instead of v3.5.2).
  • Please leave the ones using the master/main branches as is (rust-toolchain or typos actions).
  • Everything else like rust-cache and cargo-install actions can be pinned to their latest versions, specifying all of the major, minor and patch version numbers (v3.5.2 instead of v3).

Slightly unrelated, but could you also update cocogitto and git-cliff to their latest versions in the release-new-version workflow?

Thanks in advance!

@VedantKhairnar
Copy link
Contributor

Hey @Sushrut1101 ,
Let us know if you face any issues. Happy to help! : )

@SanchithHegde
Copy link
Member

Closing in favor of #2957.

@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Sushrut1101 Sushrut1101

Labels
A-CI-CD Area: Continuous Integration/Deployment hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sushrut1101 @SanchithHegde @VedantKhairnar