Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pm_list): [Trustpay] add bank_redirect - blik pm type required field info for trustpay #2390

Merged
merged 4 commits into from
Oct 3, 2023
Merged

feat(pm_list): [Trustpay] add bank_redirect - blik pm type required field info for trustpay #2390

merged 4 commits into from
Oct 3, 2023

Conversation

prasunna09
Copy link
Contributor

@prasunna09 prasunna09 commented Sep 28, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Add bank_redirect - blik pm type required field info for trustpay , and made blik_code field as optional for blik bank redirect data
Closes issue - 2435

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-09-28 at 9 12 15 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods labels Sep 28, 2023
@prasunna09 prasunna09 added this to the September 2023 Milestone milestone Sep 28, 2023
@prasunna09 prasunna09 requested a review from a team as a code owner September 28, 2023 16:28
@prasunna09 prasunna09 self-assigned this Sep 28, 2023
@prasunna09 prasunna09 requested a review from a team as a code owner September 28, 2023 16:28
ArjunKarthik
ArjunKarthik previously approved these changes Sep 28, 2023
View reviewed changes
@Chethan-rao
Copy link
Contributor

Regenerate openapi spec

@prasunna09 prasunna09 requested a review from a team as a code owner October 1, 2023 17:20
ArjunKarthik
ArjunKarthik requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@ArjunKarthik ArjunKarthik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the issue if already exists or create new issue

@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 3, 2023
@prasunna09 prasunna09 removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 3, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 3, 2023
@SanchithHegde SanchithHegde removed this pull request from the merge queue due to a manual request Oct 3, 2023
@SanchithHegde SanchithHegde added this pull request to the merge queue Oct 3, 2023
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 3, 2023
Merged via the queue into main with commit d81762a Oct 3, 2023
11 checks passed
@SanchithHegde SanchithHegde deleted the add-mandatory-fields-for-trustpay-blik branch October 3, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chethan-rao Chethan-rao Chethan-rao approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@prasunna09 prasunna09

Labels
A-connector-integration Area: Connector integration A-payment-methods Area: Payment Methods
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prasunna09 @Chethan-rao @ArjunKarthik @SanchithHegde