Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): [Cryptopay] Update PSync with connector_request_reference_id #2388

Merged
merged 3 commits into from
Oct 3, 2023
Merged

refactor(connector): [Cryptopay] Update PSync with connector_request_reference_id #2388

merged 3 commits into from
Oct 3, 2023

Conversation

prasunna09
Copy link
Contributor

@prasunna09 prasunna09 commented Sep 28, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Update PSync with connector_request_reference_id instead of connector_transaction id
Closes issue - 2434

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@prasunna09 prasunna09 added A-connector-integration Area: Connector integration S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-refactor Category: Refactor labels Sep 28, 2023
@prasunna09 prasunna09 added this to the September 2023 Milestone milestone Sep 28, 2023
@prasunna09 prasunna09 requested a review from a team as a code owner September 28, 2023 15:24
@prasunna09 prasunna09 self-assigned this Sep 28, 2023
@ArjunKarthik
Copy link
Contributor

ArjunKarthik commented Oct 3, 2023 •
edited
Loading

Please add the test screenshot and create an issue for this PR

@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 3, 2023
@prasunna09 prasunna09 removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 3, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit 3680541 Oct 3, 2023
@ArjunKarthik ArjunKarthik deleted the refactor-cryptopay-psync branch October 3, 2023 12:38
@ArjunKarthik ArjunKarthik removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srujanchikke srujanchikke srujanchikke approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@prasunna09 prasunna09

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
September 2023 Milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prasunna09 @ArjunKarthik @srujanchikke