Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payment_methods): bank details support for payment method data in pmt #2385

Merged
merged 21 commits into from
Oct 5, 2023

Conversation

Sarthak1799
Copy link
Contributor

@Sarthak1799 Sarthak1799 commented Sep 28, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added support for bank details in payment method data for payment_methods_table.
#2183 needs to go in first.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@Sarthak1799 Sarthak1799 added C-feature Category: Feature request or enhancement A-payment-methods Area: Payment Methods labels Sep 28, 2023
@Sarthak1799 Sarthak1799 requested a review from a team as a code owner September 28, 2023 10:08
@Sarthak1799 Sarthak1799 self-assigned this Sep 28, 2023
@Sarthak1799 Sarthak1799 requested review from a team as code owners September 28, 2023 10:08
@vspecky vspecky added S-ready-for-merge R-L1-completed Review: L1 Review completed R-L2-completed Review: L2 Review completed labels Oct 5, 2023
@vspecky vspecky added this to the September 2023 Milestone milestone Oct 5, 2023
@vspecky vspecky added this pull request to the merge queue Oct 5, 2023
Merged via the queue into main with commit e86c032 Oct 5, 2023
10 checks passed
@vspecky vspecky deleted the pmd-bank-details branch October 5, 2023 09:56
@SanchithHegde SanchithHegde removed S-ready-for-merge R-L1-completed Review: L1 Review completed R-L2-completed Review: L2 Review completed labels Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-payment-methods Area: Payment Methods C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants