Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kv): add kv wrapper for executing kv tasks #2384

Merged
merged 5 commits into from
Oct 9, 2023
Merged

feat(kv): add kv wrapper for executing kv tasks #2384

merged 5 commits into from
Oct 9, 2023

Conversation

dracarys18
Copy link
Member

@dracarys18 dracarys18 commented Sep 27, 2023

Type of Change

  • Enhancement

Description

Add a wrapper function to execute KV tasks.

Motivation and Context

Added a wrapper function to centralize all redis functions in a place and use the wrapper function around all KV implementations.

How did you test it?

Payment confirm

Screenshot 2023-10-09 at 3 16 13 PM

Payments retrieve
Screenshot 2023-10-09 at 3 16 52 PM

Refunds create
image

Refunds retrieve
Screenshot 2023-10-09 at 3 17 39 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@dracarys18 dracarys18 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 27, 2023
@dracarys18 dracarys18 self-assigned this Sep 27, 2023
@dracarys18 dracarys18 requested a review from a team as a code owner September 27, 2023 20:21
@dracarys18 dracarys18 added this to the September 2023 Milestone milestone Sep 27, 2023
@dracarys18 dracarys18 requested review from jarnura, ashokkjag and a team as code owners October 9, 2023 07:25
@jarnura jarnura added this pull request to the merge queue Oct 9, 2023
@jarnura jarnura added S-ready-for-merge and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Oct 9, 2023
Merged via the queue into main with commit 8b50997 Oct 9, 2023
@jarnura jarnura deleted the kv_wrapper branch October 9, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants