Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for save card in complete authorize flow #2355

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Sangamesh26
Copy link
Contributor

Type of Change

  • New feature

Description

Add save payment method, in complete authorize flow which was missing.
This fixes the issue with save card for connectors like payme thats uses complete authorize call.

Motivation and Context

Add support for save card flow in complete authorize.

How did you test it?

Steps for testing:

  1. Make payment using card through Payme with some setup_future_usage
  2. After successful payment, check payment_methods for customer, you should see the payment method that was stored.

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@Sangamesh26 Sangamesh26 added A-core Area: Core flows S-waiting-on-review Status: This PR has been implemented and needs to be reviewed A-payment-methods Area: Payment Methods labels Sep 22, 2023
@Sangamesh26 Sangamesh26 requested a review from a team as a code owner September 22, 2023 15:34
@Sangamesh26 Sangamesh26 self-assigned this Sep 22, 2023
@Sangamesh26 Sangamesh26 requested a review from a team as a code owner September 22, 2023 15:34
@pixincreate
Copy link
Member

Kindly update the postman collections for the supported connectors and update the description with the relevant screenshots.
You can refer to the rustman documentation here

@pixincreate pixincreate added the S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows A-payment-methods Area: Payment Methods S-needs-conflict-resolution Status: This PR needs conflicts to be resolved by the author S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants