-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for save card in complete authorize flow #2355
Open
Sangamesh26
wants to merge
7
commits into
main
Choose a base branch
from
propogate_error_in_tokenization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sangamesh26
added
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
A-payment-methods
Area: Payment Methods
labels
Sep 22, 2023
Sangamesh26
requested review from
ArjunKarthik,
Narayanbhat166 and
NishantJoshi00
September 22, 2023 15:34
ArjunKarthik
approved these changes
Oct 16, 2023
jarnura
approved these changes
Oct 17, 2023
Kindly update the postman collections for the supported connectors and update the description with the relevant screenshots. |
pixincreate
added
the
S-needs-conflict-resolution
Status: This PR needs conflicts to be resolved by the author
label
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
A-payment-methods
Area: Payment Methods
S-needs-conflict-resolution
Status: This PR needs conflicts to be resolved by the author
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add save payment method, in complete authorize flow which was missing.
This fixes the issue with save card for connectors like payme thats uses complete authorize call.
Motivation and Context
Add support for save card flow in complete authorize.
How did you test it?
Steps for testing:
Checklist
cargo +nightly fmt --all
cargo clippy