Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [HELCIM] Implement Cards for Helcim #2210

Merged
merged 22 commits into from
Oct 13, 2023
Merged

feat(connector): [HELCIM] Implement Cards for Helcim #2210

merged 22 commits into from
Oct 13, 2023

Conversation

deepanshu-iiitu
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Helcim is a payment connector from North America.
Add Card payment support for Helcim.

Supported Flows:

  • Authorize
  • Capture
  • PSync
  • Void
  • Refund
  • RSync

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Add Card Payments for Payments and Refunds flow for new connector helcim.

How did you test it?

Testing was carried out via Unit Tests

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@deepanshu-iiitu deepanshu-iiitu requested review from a team as code owners September 20, 2023 15:37
@deepanshu-iiitu deepanshu-iiitu self-assigned this Sep 20, 2023
@deepanshu-iiitu deepanshu-iiitu changed the title feat(connector): [HELCIM] Activate Helcim feat(connector): [HELCIM] Imlement Cards for Helcim Sep 20, 2023
@deepanshu-iiitu deepanshu-iiitu requested a review from a team as a code owner September 20, 2023 18:34
@deepanshu-iiitu deepanshu-iiitu requested a review from a team as a code owner September 21, 2023 14:15
@deepanshu-iiitu deepanshu-iiitu added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 27, 2023
ArjunKarthik
ArjunKarthik requested changes Oct 3, 2023
View reviewed changes
crates/router/src/connector/helcim.rs Outdated Show resolved Hide resolved
crates/router/src/connector/helcim.rs Outdated Show resolved Hide resolved
crates/router/src/connector/helcim.rs Show resolved Hide resolved
crates/router/src/connector/helcim.rs Outdated Show resolved Hide resolved
crates/router/src/connector/helcim.rs Outdated Show resolved Hide resolved
crates/router/src/connector/helcim/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/helcim/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/helcim/transformers.rs Show resolved Hide resolved
crates/router/src/connector/helcim/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/helcim/transformers.rs Outdated Show resolved Hide resolved
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 3, 2023
@deepanshu-iiitu deepanshu-iiitu removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 4, 2023
ArjunKarthik
ArjunKarthik requested changes Oct 9, 2023
View reviewed changes
crates/router/src/connector/helcim/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/helcim/transformers.rs Outdated Show resolved Hide resolved
crates/router/src/connector/helcim/transformers.rs Outdated Show resolved Hide resolved
@ArjunKarthik ArjunKarthik added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 9, 2023
SamraatBansal
SamraatBansal requested changes Oct 9, 2023
View reviewed changes
crates/router/src/connector/helcim.rs Outdated Show resolved Hide resolved
crates/router/src/connector/helcim.rs Show resolved Hide resolved
@deepanshu-iiitu deepanshu-iiitu removed the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label Oct 10, 2023
SanchithHegde
SanchithHegde approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@SanchithHegde SanchithHegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, looks good to me!

crates/common_enums/src/transformers.rs Show resolved Hide resolved
@SanchithHegde SanchithHegde changed the title feat(connector): [HELCIM] Imlement Cards for Helcim feat(connector): [HELCIM] Implement Cards for Helcim Oct 12, 2023
@ArjunKarthik ArjunKarthik removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Oct 13, 2023
@ArjunKarthik ArjunKarthik added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit b5feab6 Oct 13, 2023
10 of 11 checks passed
@ArjunKarthik ArjunKarthik deleted the implement-helcim-cards branch October 13, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamraatBansal SamraatBansal SamraatBansal approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

Assignees

@deepanshu-iiitu deepanshu-iiitu

Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
No open projects
hyperswitch - Public Roadmap
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deepanshu-iiitu @ArjunKarthik @SanchithHegde @SamraatBansal