Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): Add payment link support #2105

Merged
merged 61 commits into from
Oct 12, 2023
Merged

feat(router): Add payment link support #2105

merged 61 commits into from
Oct 12, 2023

Conversation

sahkal
Copy link
Contributor

@sahkal sahkal commented Sep 7, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Screenshot 2023-10-13 at 11 58 11 AM Screenshot 2023-09-07 at 10 35 44 PM Screenshot 2023-09-07 at 10 51 30 PM Screenshot 2023-10-09 at 9 57 39 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@sahkal sahkal requested review from a team, jarnura and ashokkjag as code owners September 7, 2023 17:24
@sahkal sahkal self-assigned this Sep 7, 2023
@sahkal sahkal added C-feature Category: Feature request or enhancement A-core Area: Core flows R-waiting-on-L1 Review: Waiting on L1 reviewer S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Sep 7, 2023
@sahkal sahkal added this to the September 2023 Milestone milestone Sep 7, 2023
@bernard-eugine bernard-eugine added this to the October 2023 Milestone milestone Oct 10, 2023
@sahkal sahkal requested a review from Narayanbhat166 October 10, 2023 12:33
Narayanbhat166
Narayanbhat166 previously approved these changes Oct 11, 2023
View reviewed changes
@kashif-m
feat: add cart in mobile view for payment link
2f6f372 
feat: fetch payment link's expiry date from DB to be injected in HTML
@sahkal sahkal requested a review from Narayanbhat166 October 11, 2023 19:21
jarnura
jarnura requested changes Oct 12, 2023
View reviewed changes
config/development.toml Show resolved Hide resolved
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
crates/api_models/src/payments.rs Outdated Show resolved Hide resolved
crates/api_models/src/payments.rs Show resolved Hide resolved
crates/api_models/src/payments.rs Show resolved Hide resolved
@sahkal sahkal requested a review from jarnura October 12, 2023 07:46
@jarnura jarnura enabled auto-merge October 12, 2023 09:07
@jarnura jarnura added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 642085d Oct 12, 2023
9 of 10 checks passed
@jarnura jarnura deleted the add-paymentLink-support branch October 12, 2023 09:16
@SanchithHegde SanchithHegde removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed R-waiting-on-L1 Review: Waiting on L1 reviewer labels Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Narayanbhat166 approved these changes

@jarnura jarnura jarnura approved these changes

@ashokkjag ashokkjag Awaiting requested review from ashokkjag

@sai-harsha-vardhan sai-harsha-vardhan Awaiting requested review from sai-harsha-vardhan

Assignees

@sahkal sahkal

Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Milestone
October 2023 Milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sahkal @jarnura @Narayanbhat166 @ashokkjag @SanchithHegde @bernard-eugine @kashif-m