Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add states in PayoutStatus #2059

Closed
wants to merge 18 commits into from
Closed

refactor: add states in PayoutStatus #2059

wants to merge 18 commits into from

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Aug 31, 2023

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add more states in PayoutStatus - payout lifecycle for all the integrated connectors (Adyen + Stripe + Wise) is distinct. Adding more states helps in representing the state of a payout better.

Ref

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

This will help in updating the PayoutStatus of a given payout confidently based on the payout webhooks sent by the connectors.

How did you test it?

Tested locally.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@kashif-m kashif-m requested a review from a team as a code owner August 31, 2023 09:29
@kashif-m kashif-m self-assigned this Aug 31, 2023
@kashif-m kashif-m requested review from a team as code owners August 31, 2023 09:29
@kashif-m
Copy link
Contributor Author

not needed

@kashif-m kashif-m closed this Jun 26, 2024
@SanchithHegde SanchithHegde deleted the payout_status branch June 30, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant