feat: filter out payment_methods which does not support mandates during list api call #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chethan-rao
added
C-feature
Closed
2 tasks
github-actions
bot
added
the
S-conventions-not-followed
Chethan-rao
changed the title
Chethan-rao
removed
the
S-conventions-not-followed
github-actions
bot
added
the
S-conventions-not-followed
Abhicodes-crypto
changed the title
github-actions
bot
removed
the
S-conventions-not-followed
…ter_pmd_mandates
…ter_pmd_mandates
…switch into filter_pmd_mandates
…ter_pmd_mandates
…ter_pmd_mandates
…ter_pmd_mandates
Narayanbhat166
approved these changes
Jul 11, 2023
SanchithHegde
approved these changes
Jul 11, 2023
Chethan-rao
added
R-waiting-on-L2
Chethan-rao
requested review from
jarnura and
lsampras
and removed request for
jarnura,
lsampras and
NishantJoshi00
lsampras
approved these changes
Jul 11, 2023
ashokkjag
approved these changes
Jul 14, 2023
|
|
||
| #[derive(Debug, Deserialize, Clone)] | ||
| pub struct SupportedPaymentMethodsForMandate( | ||
| pub HashMap<enums::PaymentMethod, SupportedPaymentMethodTypesForMandate>, |
There was a problem hiding this comment.
Do we need this hashmap be built through config or can there be a global static? I understand that having a config based approach will let us turn things on/off during startup, but the config structure keeps getting bloated, which gets cloned, passed to each actix thread.
There was a problem hiding this comment.
I agree that config structure is getting messy, but making it a global static will require re-deploying the application if any changes in the config right?
jarnura
approved these changes
Jul 14, 2023
jarnura
added
S-ready-for-merge
and removed
R-waiting-on-L2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
When a mandate payment is created, sdk makes a payment_method_list api call which lists all the payment_methods. But not all of them support mandate payments.
Added a filter for payment_methods which filters payment methods that doesn't support mandates and list only those which supports, during payment_method_list api call.
Created an hashmap containing info about which payment_methods through which connector, supports mandates. And while listing payment methods, validate between the merchant configured payment_methods and the supported payment_methods.
Additional Changes
crates/router/src/configs/settings.rs
Motivation and Context
List the payment_methods which support mandates filtering out others.
How did you test it?
Postman
Configured payment methods -
Filtered payment methods -
Checklist
cargo +nightly fmt --allcargo clippy