Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: [Rapyd] Use connector_response_reference_id as reference to merchant #2346

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 19 comments · Fixed by #6302
Closed
2 tasks done

[FEATURE]: [Rapyd] Use connector_response_reference_id as reference to merchant #2346

Sakilmostak opened this issue Sep 22, 2023 · 19 comments · Fixed by #6302
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions

Comments

@Sakilmostak
Copy link
Contributor

Sakilmostak commented Sep 22, 2023

📝 Feature Description

  • Reference id are used to map transactions in the connector’s dashboard.
  • Hyperswitch manages several reference ids, such as payment_id, attempt_id, and connector_transaction_id for a single transaction.
  • However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.

🔨 Possible Implementation

  • When we receive a response from the connector for the payment, we deserialize it and populate the response field in RouterData.
  • For the TransactionResponse type, we must fill the connector_response_reference_id with a corresponding reference id for the merchant to identify the transaction.
  • Please refer to the Rapyd API documentation here. In the payment response, there is a field called merchant_reference_id (an optional field). This merchant_reference_id needs to be mapped to the connector_response_reference_id.
  • You can check this PR for further reference feat(connector): [Stripe, Adyen, Checkout] Add reference ID support for retries #1735

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@Sakilmostak Sakilmostak changed the title [FEATURE]: [Rapyd] Use connector_response_reference_id as reference to merchant [FEATURE]: [Rapyd] Use connector_response_reference_id as reference to merchant Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@Abhiramjampani
Copy link

@AkshayaFoiger @VedantKhairnar @Sakilmostak I would be delighted to work on this issue
so kindly assign me this issue
Thank You : )

@AkshayaFoiger AkshayaFoiger removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 1, 2023
@AkshayaFoiger
Copy link
Contributor

Hey @Abhiramjampani , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@Abhiramjampani
Copy link

thankyou for assigning me this issue
sure !! i will consult for any queries.

@srujanchikke
Copy link
Contributor

Hi @Abhiramjampani ,

Please raise a PR to main , I have updated the issue, that how connector_resoponse_reference_id needs to mapped according to api docs of rapyd . Please re-read the issue .

@VedantKhairnar
Copy link
Contributor

Hey @Abhiramjampani ,
Let us know if you face any issues. Happy to help! : )

@VedantKhairnar
Copy link
Contributor

Hey @Abhiramjampani ,
Just checking in - are you working on it?
Let us know if you need any help.

@VedantKhairnar VedantKhairnar added the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 25, 2023
@tejas-raskar
Copy link

Hey @VedantKhairnar @Sakilmostak
I would like to work on this issue.

@VedantKhairnar
Copy link
Contributor

Hey @tejas-raskar , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with.

@VedantKhairnar VedantKhairnar removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 25, 2023
@tejas-raskar
Copy link

Hey @VedantKhairnar,
I have gone through the issue and the Rapyd docs.

I have to map the merchant_reference_id to the connector_response_reference_id.

This is how I am planning to do it:

connector_response_reference_id: Some(
    item.data.merchant_reference_id.unwrap_or(item.response.id)
)

According to the Rapyd docs, the merchant_reference_id is under data in the response. Is this approach correct?

@swangi-kumari
Copy link
Contributor

Hey @tejas-raskar ,
Please raise a PR for whatever you did as per your understanding ASAP, It will be easy for us to review from there.

@tejas-raskar
Copy link

Hey @tejas-raskar , Please raise a PR for whatever you did as per your understanding ASAP, It will be easy for us to review from there.

I have created a PR
Please review

@vinfinity7
Copy link

@swangi-kumari kindly look into PR #2724

@vinfinity7
Copy link

vinfinity7 commented Mar 17, 2024

@tejas-raskar @srujanchikke please assign me this

@swangi-kumari
Copy link
Contributor

@vinfinity7 ,
sure! We've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@vinfinity7
Copy link

@swangi-kumari the pr has been updated , it needs review #2724 & #2722

@nabeel001
Copy link
Contributor

@Sakilmostak @AkshayaFoiger
I would like to work on this issue, kindly assign this to me.

@Sakilmostak
Copy link
Contributor Author

Sure @nabeel001 , assigning this issue to you👍

@nabeel001
Copy link
Contributor

@Sakilmostak @AkshayaFoiger
Kindly review my pull request

@gorakhnathy7
Copy link
Collaborator

Hey @nabeel001
Thanks for participating!
Kindly fill this form once all of your PRs are merged.

@gorakhnathy7 gorakhnathy7 added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
10 participants