Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: [Nexi Nets] Use connector_response_reference_id as reference to merchant #2337

Closed
2 tasks done
Sakilmostak opened this issue Sep 22, 2023 · 9 comments · Fixed by #2537
Closed
2 tasks done
Assignees
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants

Comments

@Sakilmostak
Copy link
Contributor

📝 Feature Description

  • Reference id are used to map transactions in the connector’s dashboard.
  • Hyperswitch manages several reference ids, such as payment_id, attempt_id, and connector_transaction_id for a single transaction.
  • However, merchants may encounter uncertainty when determining which ID to utilize in the connector dashboard to identify the payment.

🔨 Possible Implementation

  • When we receive a response from the connector for the payment, we deserialize it and populate the response field in RouterData.
  • For the TransactionResponse type, we must fill the connector_response_reference_id with a corresponding reference id for the merchant to identify the transaction.
  • One might need to have exposure to api docs of the connector for which it is being implemented to decide what to fill in connector_response_reference_id.
  • You can check this PR for further reference feat(connector): [Stripe, Adyen, Checkout] Add reference ID support for retries #1735

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

@Sakilmostak Sakilmostak added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement S-awaiting-triage Status: New issues that have not been assessed yet hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 22, 2023
@Sakilmostak Sakilmostak changed the title [FEATURE]: [Nexi Nets] Use connector_response_reference_id as reference to merchant [FEATURE]: [Nexi Nets] Use connector_response_reference_id as reference to merchant Sep 22, 2023
@VedantKhairnar VedantKhairnar added the good first issue Good for newcomers label Sep 28, 2023
@Abhiramjampani
Copy link

@AkshayaFoiger
I would be delighted to work on this issue
so kindly assign me this
Thank You : )

@AkshayaFoiger
Copy link
Contributor

Hey @Abhiramjampani , I see that you're already assigned to #2346 and are working on it. For now, we'll leave this issue open to any other interested contributors. You may pick this up once your work on #2346 is completed, and if no other contributors have expressed interest on this. I hope that's fine by you

@SoundaryaKoutharapu
Copy link

Hi @AkshayaFoiger,
I'd like to work on this issue
can you assign this to me.?

@AkshayaFoiger AkshayaFoiger removed the S-awaiting-triage Status: New issues that have not been assessed yet label Oct 2, 2023
@AkshayaFoiger
Copy link
Contributor

Hey @SoundaryaKoutharapu , sure! I've assigned this to you.

In case you have any queries, you can ask them on this issue thread, or on our discord server, or on slack whichever you are comfortable with

@SoundaryaKoutharapu
Copy link

Hi @AkshayaFoiger sir, can you please point me to the Nexi Nets documentation please?

@AkshayaFoiger
Copy link
Contributor

Hi @SoundaryaKoutharapu ,

Please refer api docs of Nexi Nets here

@VedantKhairnar
Copy link
Contributor

Hey @SoundaryaKoutharapu ,
Let us know if you face any issues. Happy to help! : )

@SoundaryaKoutharapu SoundaryaKoutharapu removed their assignment Oct 9, 2023
@Rutam21
Copy link
Contributor

Rutam21 commented Oct 10, 2023

I have completed the previous issue and raised a PR for it. I would love to work on this now. Please assign it to me. Thank you.

CC: @AkshayaFoiger @VedantKhairnar

@Sakilmostak
Copy link
Contributor Author

Hello @Rutam21 , thanks for the submission. I have assigned this issue to you👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
6 participants