Skip to content

Commit

Permalink
fix(refunds): Add profile_id in refunds response (#2652)
Browse files Browse the repository at this point in the history
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
  • Loading branch information
pixincreate and github-actions[bot] authored Oct 25, 2023
1 parent 6428d07 commit bb86cc2
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 0 deletions.
1 change: 1 addition & 0 deletions crates/api_models/src/refunds.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ pub struct RefundResponse {
/// The connector used for the refund and the corresponding payment
#[schema(example = "stripe")]
pub connector: String,
pub profile_id: Option<String>,
}

#[derive(Debug, Clone, Eq, PartialEq, Deserialize, Serialize, ToSchema)]
Expand Down
2 changes: 2 additions & 0 deletions crates/router/src/core/refunds.rs
Original file line number Diff line number Diff line change
Expand Up @@ -602,6 +602,7 @@ pub async fn validate_and_create_refund(
.set_description(req.reason.clone())
.set_attempt_id(payment_attempt.attempt_id.clone())
.set_refund_reason(req.reason)
.set_profile_id(payment_intent.profile_id.clone())
.to_owned();

refund = db
Expand Down Expand Up @@ -704,6 +705,7 @@ impl ForeignFrom<storage::Refund> for api::RefundResponse {
currency: refund.currency.to_string(),
reason: refund.refund_reason,
status: refund.refund_status.foreign_into(),
profile_id: refund.profile_id,
metadata: refund.metadata,
error_message: refund.refund_error_message,
error_code: refund.refund_error_code,
Expand Down
4 changes: 4 additions & 0 deletions openapi/openapi_spec.json
Original file line number Diff line number Diff line change
Expand Up @@ -10680,6 +10680,10 @@
"type": "string",
"description": "The connector used for the refund and the corresponding payment",
"example": "stripe"
},
"profile_id": {
"type": "string",
"nullable": true
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,13 @@ if (jsonData?.refund_id) {
"INFO - Unable to assign variable {{refund_id}}, as jsonData.refund_id is undefined.",
);
}


// Response body should have "profile_id" and not "null"
pm.test(
"[POST]::/payments - Content check if 'profile_id' exists and is not 'null'",
function () {
pm.expect(typeof jsonData.profile_id !== "undefined").to.be.true;
pm.expect(jsonData.profile_id).is.not.null;
},
);

0 comments on commit bb86cc2

Please sign in to comment.