Skip to content

Commit

Permalink
address pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ShankarSinghC committed Nov 29, 2023
1 parent 2e30b55 commit 7fef2ff
Showing 1 changed file with 16 additions and 8 deletions.
24 changes: 16 additions & 8 deletions crates/router/src/core/payment_methods/cards.rs
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,10 @@ pub async fn add_card_to_locker(
})
},
&metrics::CARD_ADD_TIME,
&[router_env::opentelemetry::KeyValue::new(
"locker", "basilisk",
)],
&[
router_env::opentelemetry::KeyValue::new("locker", "basilisk"),
router_env::opentelemetry::KeyValue::new("operation", "add"),
],
)
.await?;
logger::debug!("card added to basilisk locker");
Expand All @@ -259,7 +260,10 @@ pub async fn add_card_to_locker(
metrics::CARD_LOCKER_FAILURES.add(
&metrics::CONTEXT,
1,
&[router_env::opentelemetry::KeyValue::new("locker", "rust")],
&[
router_env::opentelemetry::KeyValue::new("locker", "rust"),
router_env::opentelemetry::KeyValue::new("operation", "add"),
],
);
error
})
Expand Down Expand Up @@ -321,7 +325,10 @@ pub async fn get_card_from_locker(
metrics::CARD_LOCKER_FAILURES.add(
&metrics::CONTEXT,
1,
&[router_env::opentelemetry::KeyValue::new("locker", "rust")],
&[
router_env::opentelemetry::KeyValue::new("locker", "rust"),
router_env::opentelemetry::KeyValue::new("operation", "get"),
],
);
error
})
Expand All @@ -348,9 +355,10 @@ pub async fn get_card_from_locker(
metrics::CARD_LOCKER_FAILURES.add(
&metrics::CONTEXT,
1,
&[router_env::opentelemetry::KeyValue::new(
"locker", "basilisk",
)],
&[
router_env::opentelemetry::KeyValue::new("locker", "basilisk"),
router_env::opentelemetry::KeyValue::new("operation", "get"),
],
);
error
})
Expand Down

0 comments on commit 7fef2ff

Please sign in to comment.