fix(events): fix default values for request body

juspay · Dec 12, 2023 · 17c1126 · 17c1126
1 parent ee3e3f4
commit 17c1126
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 15 deletions.
diff --git a/config/development.toml b/config/development.toml
@@ -510,7 +510,7 @@ intent_analytics_topic = "hyperswitch-payment-intent-events"
 attempt_analytics_topic = "hyperswitch-payment-attempt-events"
 refund_analytics_topic = "hyperswitch-refund-events"
 api_logs_topic = "hyperswitch-api-log-events"
-connector_events_topic = "hyperswitch-connector-api-events"
+connector_logs_topic = "hyperswitch-connector-api-events"
 
 [analytics]
 source = "sqlx"

diff --git a/crates/pm_auth/src/types/api.rs b/crates/pm_auth/src/types/api.rs
@@ -39,7 +39,7 @@ pub trait ConnectorIntegration<T, Req, Resp>: ConnectorIntegrationAny<T, Req, Re
         &self,
         _req: &super::PaymentAuthRouterData<T, Req, Resp>,
     ) -> CustomResult<RequestContent, ConnectorError> {
-        Ok(RequestContent::Json(Box::new(serde_json::json!(r#""#))))
+        Ok(RequestContent::Json(Box::new(serde_json::json!(r#"{}"#))))
     }
 
     fn build_request(

diff --git a/crates/router/src/connector/cybersource.rs b/crates/router/src/connector/cybersource.rs
@@ -466,13 +466,6 @@ impl ConnectorIntegration<api::PSync, types::PaymentsSyncData, types::PaymentsRe
         self.common_get_content_type()
     }
 
-    fn get_request_body(
-        &self,
-        _req: &types::PaymentsSyncRouterData,
-        _connectors: &settings::Connectors,
-    ) -> CustomResult<RequestContent, errors::ConnectorError> {
-        Ok(RequestContent::Json(Box::new(serde_json::json!({}))))
-    }
     fn build_request(
         &self,
         req: &types::PaymentsSyncRouterData,
@@ -818,9 +811,6 @@ impl ConnectorIntegration<api::RSync, types::RefundsData, types::RefundsResponse
                 .url(&types::RefundSyncType::get_url(self, req, connectors)?)
                 .attach_default_headers()
                 .headers(types::RefundSyncType::get_headers(self, req, connectors)?)
-                .set_body(types::RefundSyncType::get_request_body(
-                    self, req, connectors,
-                )?)
                 .build(),
         ))
     }

diff --git a/crates/router/src/services/api.rs b/crates/router/src/services/api.rs
@@ -138,7 +138,7 @@ pub trait ConnectorIntegration<T, Req, Resp>: ConnectorIntegrationAny<T, Req, Re
         _req: &types::RouterData<T, Req, Resp>,
         _connectors: &Connectors,
     ) -> CustomResult<RequestContent, errors::ConnectorError> {
-        Ok(RequestContent::Json(Box::new(json!(r#""#))))
+        Ok(RequestContent::Json(Box::new(json!(r#"{}"#))))
     }
 
     fn get_request_form_data(
@@ -287,7 +287,8 @@ where
         Some(RequestContent::Json(payload))
         | Some(RequestContent::FormUrlEncoded(payload))
         | Some(RequestContent::Xml(payload)) => payload.masked_serialize().unwrap_or_default(),
-        _ => serde_json::Value::Null,
+        Some(RequestContent::FormData(_)) => json!({"request_type": "FORM_DATA"}),
+        None => serde_json::Value::Null,
     });
     logger::debug!(connector_request_body=?masked_conn_req);
     logger::debug!(payment_id=?req.payment_id);
@@ -374,7 +375,7 @@ where
                                 .unwrap_or(json!({ "error": "failed to mask serialize"})),
                             RequestContent::FormData(_) => json!({"request_type": "FORM_DATA"}),
                         },
-                        None => json!({"error": "EMPTY_REQUEST_BODY"}),
+                        None => serde_json::Value::Null,
                     };
                     let request_url = request.url.clone();
                     let request_method = request.method;