Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cobaged ux enhancement and added icon for CB #834

Merged
merged 3 commits into from
Dec 11, 2024
Merged

refactor: cobaged ux enhancement and added icon for CB #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e8ecb7
feat: added icon for cartesbancaires
aritro2002 Dec 11, 2024
7fd5238
refactor: ux enhancement
Sanskar2001 Dec 11, 2024
8b7e309
Merge branch 'main' into cb-ui
PritishBudhiraja Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions public/icons/orca.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/CardSchemeComponent.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ let make = (~cardNumber, ~paymentType, ~cardBrand, ~setCardBrand) => {

<div className={`${animate} flex items-center ${marginLeft} hellow-rodl`}>
cardBrandIcon
<RenderIf condition={isCardCoBadged}>
<RenderIf condition={isCardCoBadged && cardNumber->CardUtils.clearSpaces->String.length >= 16}>
<CoBadgeCardSchemeDropDown eligibleCardSchemes setCardBrand />
</RenderIf>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/CardUtils.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ let getCardBrandIcon = (cardType, paymentType) => {
| SODEXO => <Icon size=brandIconSize name="card" />
| RUPAY => <Icon size=brandIconSize name="rupay-card" />
| JCB => <Icon size=brandIconSize name="jcb-card" />
| CARTESBANCAIRES => <Icon size=brandIconSize name="card" />
| CARTESBANCAIRES => <Icon size=brandIconSize name="cartesbancaires-card" />
| UNIONPAY => <Icon size=brandIconSize name="card" />
| INTERAC => <Icon size=brandIconSize name="interac" />
| NOTFOUND =>
Expand Down
Loading