Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: stringify json for block confirm body and headers #798

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

sakksham7
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Stringified the json body and headers for block confirm call

How did you test it?

by blocking the confirm call and checking logs

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sakksham7 sakksham7 added the Ready for Review PR with label Ready for Review should only be reviewed. label Nov 14, 2024
@sakksham7 sakksham7 self-assigned this Nov 14, 2024
Copy link

Review changes with  SemanticDiff

@PritishBudhiraja PritishBudhiraja merged commit 1aaf1f7 into main Nov 14, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the block-confirm branch November 14, 2024 11:16
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants