Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added dynamic fields support for sepa bank transfer #775

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

sakksham7
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added dynamic fields support for sepa bank transfer

How did you test it?

Tested via not passing email to a new customer_id and checking whether it is getting rendered through dynamic fields or not.
Tested via passing all the values and checking no field should be rendered

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@sakksham7 sakksham7 added the Ready for Review PR with label Ready for Review should only be reviewed. label Nov 6, 2024
@sakksham7 sakksham7 self-assigned this Nov 6, 2024
@sakksham7 sakksham7 requested a review from seekshiva as a code owner November 6, 2024 13:09
Copy link

Review changes with  SemanticDiff

src/Utilities/PaymentBody.res Outdated Show resolved Hide resolved
@PritishBudhiraja PritishBudhiraja merged commit 52d2d15 into main Nov 7, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the dynamic-sepa-transfer branch November 7, 2024 06:22
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Nov 7, 2024
PritishBudhiraja pushed a commit that referenced this pull request Nov 7, 2024
# [0.101.0](v0.100.1...v0.101.0) (2024-11-07)

### Features

* added dynamic fields support for sepa bank transfer ([#775](#775)) ([52d2d15](52d2d15))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants