Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(redirection): allow redirections in root context #774

Merged
merged 10 commits into from
Nov 7, 2024
Merged

refactor(redirection): allow redirections in root context #774

merged 10 commits into from
Nov 7, 2024

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Nov 6, 2024 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Described in #773

Testing

Payment links with top redirection: true
payment_link.webm

Payout links with top redirection: true
payout_link.webm

Payment links with top redirection: false (for preserving current SDK behaviour)
payment_link_no_top_redirection.webm

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@kashif-m kashif-m self-assigned this Nov 6, 2024
@kashif-m kashif-m linked an issue Nov 6, 2024 that may be closed by this pull request
[REFACTOR] handle iframe redirections #773
Closed
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@kashif-m kashif-m removed a link to an issue Nov 6, 2024
[REFACTOR] handle iframe redirections #773
Closed
@kashif-m kashif-m linked an issue Nov 6, 2024 that may be closed by this pull request
[REFACTOR] handle iframe redirections #773
Closed
@kashif-m kashif-m marked this pull request as ready for review November 6, 2024 12:19
@PritishBudhiraja PritishBudhiraja added Enhancement / Refactoring New feature or request or any refactoring Ready for Review PR with label Ready for Review should only be reviewed. labels Nov 6, 2024
PritishBudhiraja
PritishBudhiraja previously approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seekshiva
seekshiva requested changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@seekshiva seekshiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By convention, react hooks start with use.

Rename useTopRedirection -> shouldUseTopRedirection to avoid confusion that this is a hook

@kashif-m kashif-m requested a review from seekshiva November 7, 2024 07:08
@PritishBudhiraja PritishBudhiraja merged commit 56249ee into main Nov 7, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the 773-feature-handle-iframe-redirections branch November 7, 2024 11:15
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Enhancement / Refactoring New feature or request or any refactoring Ready for Review PR with label Ready for Review should only be reviewed. labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@seekshiva seekshiva seekshiva approved these changes

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

Assignees

@kashif-m kashif-m

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] handle iframe redirections
3 participants
@kashif-m @seekshiva @PritishBudhiraja