Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add text overflow with ellipsis in dropdown #745

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

aritro2002
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

When billing details are rendered then text inside the dropdown is overflowing

Before:
Screenshot 2024-10-15 at 2 39 52 PM
Screenshot 2024-10-21 at 4 33 52 PM

After:
Screenshot 2024-10-21 at 4 13 59 PM
Screenshot 2024-10-21 at 4 14 23 PM

How did you test it?

Tested via rendering the SDK in safari and chrome

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

Copy link

Review changes with SemanticDiff.

@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Oct 21, 2024
@PritishBudhiraja PritishBudhiraja linked an issue Oct 21, 2024 that may be closed by this pull request
@PritishBudhiraja PritishBudhiraja removed a link to an issue Oct 21, 2024
@PritishBudhiraja PritishBudhiraja linked an issue Oct 21, 2024 that may be closed by this pull request
@PritishBudhiraja PritishBudhiraja merged commit 9061306 into main Oct 21, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the fix/billing-ui branch October 21, 2024 11:49
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Oct 21, 2024
PritishBudhiraja pushed a commit that referenced this pull request Oct 21, 2024
## [0.95.3](v0.95.2...v0.95.3) (2024-10-21)

### Bug Fixes

* add text overflow with ellipsis in dropdown ([#745](#745)) ([9061306](9061306))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown Arrow styling fix
2 participants