feat: added apple pay support inside an iframe #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArushKapoorJuspay
requested review from
seekshiva and
PritishBudhiraja
as code owners
|
Review changes with SemanticDiff. |
ArushKapoorJuspay
temporarily deployed
to
Testing
GitHub Actions
Inactive
PritishBudhiraja
added
the
Ready for Review
Comment on lines
+189
to
+205
| let handleApplePayIframePostMessage = (msg, componentName, mountedIframeRef) => { | ||
| let isApplePayMessageSent = ref(false) | ||
|
|
||
| let iframes = Window.querySelectorAll("iframe") | ||
|
|
||
| iframes->Array.forEach(iframe => { | ||
| let iframeSrc = iframe->Window.getAttribute("src")->Option.getOr("") | ||
| if iframeSrc->String.includes(`componentName=${componentName}`) { | ||
| iframe->Js.Nullable.return->Window.iframePostMessage(msg) | ||
| isApplePayMessageSent := true | ||
| } | ||
| }) | ||
|
|
||
| if !isApplePayMessageSent.contents { | ||
| mountedIframeRef->Window.iframePostMessage(msg) | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| let handleApplePayIframePostMessage = (msg, componentName, mountedIframeRef) => { | |
| let isApplePayMessageSent = ref(false) | |
| let iframes = Window.querySelectorAll("iframe") | |
| iframes->Array.forEach(iframe => { | |
| let iframeSrc = iframe->Window.getAttribute("src")->Option.getOr("") | |
| if iframeSrc->String.includes(`componentName=${componentName}`) { | |
| iframe->Js.Nullable.return->Window.iframePostMessage(msg) | |
| isApplePayMessageSent := true | |
| } | |
| }) | |
| if !isApplePayMessageSent.contents { | |
| mountedIframeRef->Window.iframePostMessage(msg) | |
| } | |
| } | |
| let handleApplePayIframePostMessage = (msg, componentName, mountedIframeRef) => { | |
| let isApplePayMessageSent = ref(false) | |
| let iframes = Window.querySelectorAll("iframe") | |
| iframes->Array.forEach(iframe => | |
| if ( | |
| iframe | |
| ->Window.getAttribute("src") | |
| ->Option.getOr("") | |
| ->String.includes(`componentName=${componentName}`) | |
| ) { | |
| iframe->Nullable.make->Window.iframePostMessage(msg) | |
| isApplePayMessageSent := true | |
| } | |
| ) | |
| if !isApplePayMessageSent.contents { | |
| mountedIframeRef->Window.iframePostMessage(msg) | |
| } | |
| } |
| @@ -250,9 +241,9 @@ let useHandleApplePayResponse = ( | |||
| let json = ev.data->safeParse | |||
| try { | |||
| let dict = json->getDictFromJson | |||
| if dict->Dict.get("applePayProcessPayment")->Option.isSome { | |||
| if dict->Dict.get("applePayPaymentToken")->Option.isSome { | |||
There was a problem hiding this comment.
Suggested change
| if dict->Dict.get("applePayPaymentToken")->Option.isSome { | |
| if dict->getDictIsSome("applePayPaymentToken") { |
Comment on lines
+105
to
+106
| ->Dict.fromArray | ||
| ->JSON.Encode.object |
There was a problem hiding this comment.
Suggested change
| ->Dict.fromArray | |
| ->JSON.Encode.object | |
| ->getJsonFromArrayOfJson |
Comment on lines
+116
to
+117
| ->Dict.fromArray | ||
| ->JSON.Encode.object |
There was a problem hiding this comment.
Suggested change
| ->Dict.fromArray | |
| ->JSON.Encode.object | |
| ->getJsonFromArrayOfJson |
seekshiva
approved these changes
Oct 23, 2024
github-actions
bot
added
Closed
Ayyanaruto
pushed a commit
to Ayyanaruto/hyperswitch-web
that referenced
this pull request
Oct 24, 2024
# [0.96.0](juspay/hyperswitch-web@v0.95.3...v0.96.0) (2024-10-23) ### Features * added apple pay support inside an iframe ([juspay#743](juspay#743)) ([44ed3a8](juspay@44ed3a8))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Implemented support for initiating an ApplePay session within an iframe, provided that a HyperLoader script is present at the parent level.
How did you test it?
Checklist
npm run re:build