Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: closed loader before calling merchant callback #741

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

sakksham7
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Closed loader if there is any before executing the merchant callback

How did you test it?

By passing a onPaymentComplete callback and checking if the loader is getting closed or not

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

Copy link

Review changes with SemanticDiff.

@PritishBudhiraja PritishBudhiraja added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit c0d4e15 Oct 16, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the loader-removed branch October 16, 2024 13:39
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label Oct 16, 2024
akash-c-k pushed a commit that referenced this pull request Oct 16, 2024
## [0.95.1](v0.95.0...v0.95.1) (2024-10-16)

### Bug Fixes

* closed loader before calling merchant callback ([#741](#741)) ([c0d4e15](c0d4e15))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants