Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sdk pay now redirect fix #715

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: sdk pay now redirect fix #715

merged 1 commit into from
Oct 4, 2024

Conversation

sakksham7
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

SDK was redirecting everytime in case of SDK pay now button was clicked, fixed it by adding a condition of only redirect when submit successfull is true.

How did you test it?

by trying to click on pay now without providing all fields

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

Copy link

Review changes with SemanticDiff.

@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Oct 4, 2024
@PritishBudhiraja PritishBudhiraja merged commit 2bdf260 into main Oct 4, 2024
3 checks passed
@PritishBudhiraja PritishBudhiraja deleted the sdk-pay-now branch October 4, 2024 09:14
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Oct 4, 2024
akash-c-k pushed a commit that referenced this pull request Oct 4, 2024
## [0.91.3](v0.91.2...v0.91.3) (2024-10-04)

### Bug Fixes

* sdk pay now redirect fix ([#715](#715)) ([2bdf260](2bdf260))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants