fix: paypal flow fixed for one click handler #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakksham7
added
the
Ready for Review
sakksham7
requested review from
seekshiva,
PritishBudhiraja and
ArushKapoorJuspay
|
Review changes with SemanticDiff. |
PritishBudhiraja
previously approved these changes
Oct 4, 2024
ArushKapoorJuspay
approved these changes
Oct 4, 2024
github-actions
bot
added
Closed
akash-c-k
pushed a commit
that referenced
this pull request
Oct 4, 2024
## [0.91.7](v0.91.6...v0.91.7) (2024-10-04) ### Bug Fixes * paypal flow fixed for one click handler ([#711](#711)) ([09a8470](09a8470))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
In case of merchant passing
sdkHandleOneClickConfirmPaymentas false , paypal button was not rendering as themakeOneClickHandlerPromisewas attached before the on click of the paypal button, that has been fixed by moving it to thecreateOrder()section of paypalHow did you test it?
By passing
sdkHandleOneClickConfirmPaymentas false and checking the paypal flow.Checklist
npm run re:build