Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added dynamic fields for SEPA #624

Merged
merged 19 commits into from
Oct 29, 2024
Merged

feat: added dynamic fields for SEPA #624

merged 19 commits into from
Oct 29, 2024

Conversation

PritishBudhiraja
Copy link
Collaborator

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Added dynamic fields for SEPA Bank Debit

How did you test it?

For now hardcoded the response and use but will test with the proper response when everything will be in integ.

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@PritishBudhiraja PritishBudhiraja added the Development In Progress Use this label if you have raised the PR but development is still under progress label Sep 18, 2024
@PritishBudhiraja PritishBudhiraja self-assigned this Sep 18, 2024
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Sep 18, 2024 •
edited
Loading

Review changes with SemanticDiff.

@PritishBudhiraja PritishBudhiraja added Ready for Review PR with label Ready for Review should only be reviewed. and removed Development In Progress Use this label if you have raised the PR but development is still under progress labels Sep 30, 2024
seekshiva
seekshiva requested changes Sep 30, 2024
View reviewed changes
src/Utilities/Utils.res Outdated Show resolved Hide resolved
@sakksham7 sakksham7 added DO NOT MERGE Use this label if you want your PR to restrict from merging and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Oct 1, 2024
@PritishBudhiraja PritishBudhiraja linked an issue Oct 22, 2024 that may be closed by this pull request
SEPA dynamic fields #587
Closed
@sakksham7 sakksham7 added Ready for Review PR with label Ready for Review should only be reviewed. and removed DO NOT MERGE Use this label if you want your PR to restrict from merging labels Oct 23, 2024
@PritishBudhiraja PritishBudhiraja merged commit 63f536e into main Oct 29, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the feat/sepa-debit branch October 29, 2024 08:28
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Oct 29, 2024
PritishBudhiraja pushed a commit that referenced this pull request Oct 29, 2024
@semantic-release-bot
chore(release): 0.98.0 [skip ci]
344855d 
# [0.98.0](v0.97.0...v0.98.0) (2024-10-29)

### Features

* added dynamic fields for SEPA ([#624](#624)) ([63f536e](63f536e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sakksham7 sakksham7 sakksham7 left review comments

@seekshiva seekshiva seekshiva approved these changes

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

@Sanskar2001 Sanskar2001 Awaiting requested review from Sanskar2001

Assignees

@PritishBudhiraja PritishBudhiraja

@ArushKapoorJuspay ArushKapoorJuspay

@sakksham7 sakksham7

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SEPA dynamic fields
4 participants
@PritishBudhiraja @seekshiva @sakksham7 @ArushKapoorJuspay