Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payout): on change handler for dropdown #615

Merged
merged 4 commits into from
Sep 16, 2024
Merged

fix(payout): on change handler for dropdown #615

merged 4 commits into from
Sep 16, 2024

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Sep 16, 2024 •
edited
Loading

make SEPA BIC optional
populate default requiredFields in case backend returns an empty response

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR contains below fixes

  • update form value on change in dropdown fields (country code not updating)
  • use default fields for payment method data form in case backend returns an empty response
  • add validation for IBAN and make BIC optional

How did you test it?

Locally.

Screencast.from.16-09-24.03.30.14.PM.IST.webm

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@kashif-m
fix(payout): on change handler for dropdown
13b2b1e 
make SEPA BIC optional
populate default requiredFields in case backend returns an empty response
@kashif-m kashif-m self-assigned this Sep 16, 2024
@kashif-m kashif-m linked an issue Sep 16, 2024 that may be closed by this pull request
[FEATURE] dynamic fields support for payout widget #593
Closed
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with SemanticDiff.

@kashif-m kashif-m marked this pull request as ready for review September 16, 2024 09:32
PritishBudhiraja
PritishBudhiraja approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good :)

@PritishBudhiraja PritishBudhiraja merged commit 750b8c6 into main Sep 16, 2024
5 checks passed
@PritishBudhiraja PritishBudhiraja deleted the 593-feature-dynamic-fields-support-for-payout-widget branch September 16, 2024 10:35
@github-actions github-actions bot added the Closed Label will be automatically added when the PR will get merged to main label Sep 16, 2024
akash-c-k pushed a commit that referenced this pull request Sep 16, 2024
@semantic-release-bot
chore(release): 0.86.2 [skip ci]
fe2f777 
## [0.86.2](v0.86.1...v0.86.2) (2024-09-16)

### Bug Fixes

* **payout:** on change handler for dropdown ([#615](#615)) ([750b8c6](750b8c6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

Assignees

@kashif-m kashif-m

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] dynamic fields support for payout widget
2 participants
@kashif-m @PritishBudhiraja