Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: variant to str mapper refactor #607

Merged
merged 4 commits into from
Nov 4, 2024
Merged

refactor: variant to str mapper refactor #607

merged 4 commits into from
Nov 4, 2024

Conversation

Sanskar2001
Copy link
Contributor

@Sanskar2001 Sanskar2001 commented Sep 10, 2024 •
edited by PritishBudhiraja
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Code level changes as no mapper is needed.

How did you test it?

Code compilation and logs via network.

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Sep 10, 2024 •
edited
Loading

Review changes with  SemanticDiff

PritishBudhiraja
PritishBudhiraja previously approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@PritishBudhiraja PritishBudhiraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@PritishBudhiraja PritishBudhiraja added the Ready for Review PR with label Ready for Review should only be reviewed. label Sep 11, 2024
sakksham7
sakksham7 previously approved these changes Sep 11, 2024
View reviewed changes
@PritishBudhiraja PritishBudhiraja dismissed stale reviews from vsrivatsa-edinburgh, sakksham7, and themself via d164848 November 4, 2024 14:18
@PritishBudhiraja PritishBudhiraja merged commit 18599f7 into main Nov 4, 2024
4 checks passed
@PritishBudhiraja PritishBudhiraja deleted the variant-to-string-refactor branch November 4, 2024 14:20
@github-actions github-actions bot added Closed Label will be automatically added when the PR will get merged to main and removed Ready for Review PR with label Ready for Review should only be reviewed. labels Nov 4, 2024
@vsrivatsa-edinburgh
Copy link
Member

@Shivam25092001 this is exactly what we were discussing, if you recall :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PritishBudhiraja PritishBudhiraja PritishBudhiraja approved these changes

@vsrivatsa-edinburgh vsrivatsa-edinburgh vsrivatsa-edinburgh left review comments

@sakksham7 sakksham7 sakksham7 left review comments

@seekshiva seekshiva Awaiting requested review from seekshiva seekshiva is a code owner

@ArushKapoorJuspay ArushKapoorJuspay Awaiting requested review from ArushKapoorJuspay ArushKapoorJuspay is a code owner

Assignees

@Sanskar2001 Sanskar2001

Labels
Closed Label will be automatically added when the PR will get merged to main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sanskar2001 @vsrivatsa-edinburgh @PritishBudhiraja @sakksham7